From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAXSr-0005Uk-EU for qemu-devel@nongnu.org; Wed, 08 Jun 2016 02:59:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAXSl-0000Xx-H2 for qemu-devel@nongnu.org; Wed, 08 Jun 2016 02:59:44 -0400 References: <1465313980-31281-1-git-send-email-thuth@redhat.com> <1465313980-31281-5-git-send-email-thuth@redhat.com> <20160608054448.GV9226@voom.fritz.box> From: Thomas Huth Message-ID: <5757C252.8030803@redhat.com> Date: Wed, 8 Jun 2016 08:59:30 +0200 MIME-Version: 1.0 In-Reply-To: <20160608054448.GV9226@voom.fritz.box> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7vF3itL0m4O85Xo3Fp6Jm96L74MAer494" Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] ppc: Improve PCR bit selection in ppc_set_compat() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7vF3itL0m4O85Xo3Fp6Jm96L74MAer494 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08.06.2016 07:44, David Gibson wrote: > On Tue, Jun 07, 2016 at 05:39:39PM +0200, Thomas Huth wrote: >> When using an olderr PowerISA level, all the upper compatibility >> bits have to be enabled, too. For example when we want to run >> something in PowerISA 2.05 compatibility mode on POWER8, the bit >> for 2.06 has to be set beside the bit for 2.05. >> Additionally, to make sure that we do not set bits that are not >> supported by the host, we apply a mask with the known-to-be-good >> bits here, too. >> >> Signed-off-by: Thomas Huth >=20 > So, this breaks compile on 32-bit targets, because the spr values are > only 32-bit there, and the PCR constants exceed that. But > ppc_set_compat() is only actually used on 64-bit machines, so I've > added a change to #if it out for 64-bit targets. D'oh, I explicitly compiled everything with a mingw32 cross-compiler to catch such issues ... but apparently it compiled without -Werror here, so I did not notice the warning :-( Thanks for the fixup! Thomas --7vF3itL0m4O85Xo3Fp6Jm96L74MAer494 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXV8JWAAoJEC7Z13T+cC21kagP/3KWSHgjpZYrDzpiOQAWY211 cV9O8HyTH3xwB8ZccmGMVzUJ+lvxS7ldPf8ZimNDJQase3RTBlAOnK+2WOdHUriT AbvgwLdU0pHwLCoISgWNQ9CNh2NsOsd7+6zZ6Hv5gP2p7jR9e8bWunGInZEdb0ks 1x9PeSLQiYq6TcvLYnotD3dwux2rEo9zKRpOWZXAareHScWu5qEWfmMdNInlQrtJ XpFoJbl+YioeZzoIY342xCI2oR2huEzKlxOv7jCy/hNb60sOhwZ3nynuzg+TTHiJ 8uDNf1R+pMEvy5zmZFJaatwz/roHv1mXOiGzIcU2VWjoA2+w1rX+WLXvIaplzIsb PzhBt6/uyAPlYMElMbLvRPrQHQXOnU+oOPzEYwYxyW43A1hKXe3vCplqOmPm3aUV T+DQM+ysbneqUOKGxUFN5tzNU7QACwSEsfEn+b2yLuHAkRVTaSsI7bnc5RDwpU1L AF/2GQeINSSlZskUqPWJxfonDBZPHO9rdNw4PoUgQXAwmSSr2aFxmZNuBFsE+iiO CH0lWiy4I0cn2rQ0Z1rnexklMwIyIFNw1QsopQrBjSr098LI9IUp/m00SvShdWg4 EdukGrhL1vA/hBevo7Sa8ybYYzsf9v8oYNrv8WeGdzbtWTAt2E5BaUMXnECXr7rK hWgp6HPMo7qpVWWM28Ka =Y1IX -----END PGP SIGNATURE----- --7vF3itL0m4O85Xo3Fp6Jm96L74MAer494--