From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAY3r-0006AB-2P for qemu-devel@nongnu.org; Wed, 08 Jun 2016 03:38:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAY3m-0001MB-Ut for qemu-devel@nongnu.org; Wed, 08 Jun 2016 03:37:58 -0400 References: <1465313980-31281-1-git-send-email-thuth@redhat.com> <1465313980-31281-5-git-send-email-thuth@redhat.com> <20160608054448.GV9226@voom.fritz.box> <5757C252.8030803@redhat.com> <20160608072459.GB9226@voom.fritz.box> From: Thomas Huth Message-ID: <5757CB47.5050102@redhat.com> Date: Wed, 8 Jun 2016 09:37:43 +0200 MIME-Version: 1.0 In-Reply-To: <20160608072459.GB9226@voom.fritz.box> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oaScO0HJxbVeJpiCivt5Q4rgCG6x12xNj" Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] ppc: Improve PCR bit selection in ppc_set_compat() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oaScO0HJxbVeJpiCivt5Q4rgCG6x12xNj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08.06.2016 09:24, David Gibson wrote: > On Wed, Jun 08, 2016 at 08:59:30AM +0200, Thomas Huth wrote: >> On 08.06.2016 07:44, David Gibson wrote: >>> On Tue, Jun 07, 2016 at 05:39:39PM +0200, Thomas Huth wrote: >>>> When using an olderr PowerISA level, all the upper compatibility >>>> bits have to be enabled, too. For example when we want to run >>>> something in PowerISA 2.05 compatibility mode on POWER8, the bit >>>> for 2.06 has to be set beside the bit for 2.05. >>>> Additionally, to make sure that we do not set bits that are not >>>> supported by the host, we apply a mask with the known-to-be-good >>>> bits here, too. >>>> >>>> Signed-off-by: Thomas Huth >>> >>> So, this breaks compile on 32-bit targets, because the spr values are= >>> only 32-bit there, and the PCR constants exceed that. But >>> ppc_set_compat() is only actually used on 64-bit machines, so I've >>> added a change to #if it out for 64-bit targets. >> >> D'oh, I explicitly compiled everything with a mingw32 cross-compiler t= o >> catch such issues ... but apparently it compiled without -Werror here,= >> so I did not notice the warning :-( >=20 > No, not 32-bit *host*, 32-bit *target*, so mingw32 wouldn't help. > Configuring in ppc-softmmu and ppcemb-softmmu would. Ok, right, ... I've now enabled these in my compile-test folder, too. Anyway, seems like mingw is compiled without -Werror by default, unlike the Linux builds ... I guess we could enable -Werror by default on mingw nowadays, too... Thomas --oaScO0HJxbVeJpiCivt5Q4rgCG6x12xNj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXV8tOAAoJEC7Z13T+cC219bgP/0Nj3itnY3t3e3osmIwxWfJ3 ZAR/S79iTKxdoNdfU1y7tttRjsoP3HCUb8hzU3Dy36YLVGgjIQB0HAXSQNhVfSvh EYSk6awbFxT1S+PWlfT+RRhd+JyJBQXP8P6ib0sNclZR5NNIQ46KCJGnLudHbvZ5 uRuEPOYZ1KgGyt0I/gfYRNKtTi3ZYre0sSvgxAhPK/cxAhSEhaYvLxzwApzG9PdY tdF8o25e0LFJ4jnzijhnNBw2fs5CNpvIjUCd7OUcxTC8gTEIgoE/Fu9kyFE/5qBW hNytgZ/tBinwZSlM1FgmgT8X5S4qdXHrIytymNPZ87zS4fmT0i5ypB7TbpN5Sda0 F4/a2Y6rtAVDV+s2nJzuHni1U2dEX7VGMlhFATl0fRnzH4QKj6oW8NsjaoYUvjUT Abp1eK8DQOqkhvFUHvDbybIXI/kM1OZpT7oNn/AG4gpYT/AWpGyzB4SkVHAkB/Gl tlofrSuTXKSI090XFnrqkUv+pj1Vd5VSbakIq1TaYWWMLXH9UgZaZf2L9wvgtJT+ 02Gcl+pmxRxGxIVeY+pJDOEstKmomZPe/yvu4E+g0S6Smk4F8bVTQgMP2Tcjs+/R DGkw85XwaTVPwTTU6JhEjfeWxB/hXpwX2REFyUgUFBuLhCx7CeA88cNLsNLEb722 9R16kRikwzV8C5yHMVTB =2VBu -----END PGP SIGNATURE----- --oaScO0HJxbVeJpiCivt5Q4rgCG6x12xNj--