From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: Peter Xu <peterx@redhat.com>, Marcel Apfelbaum <marcel@redhat.com>
Cc: ehabkost@redhat.com, mst@redhat.com, bd.aviv@gmail.com,
qemu-devel@nongnu.org, alex.williamson@redhat.com,
jan.kiszka@web.de, pbonzini@redhat.com, davidkiarie4@gmail.com
Subject: Re: [Qemu-devel] [PATCH v2 3/3] q35: allow dynamic sysbus
Date: Wed, 8 Jun 2016 14:18:58 +0300 [thread overview]
Message-ID: <5757FF22.3090209@gmail.com> (raw)
In-Reply-To: <20160608025645.GJ1039@pxdev.xzpeter.org>
On 06/08/2016 05:56 AM, Peter Xu wrote:
> On Thu, Jun 02, 2016 at 11:15:55PM +0300, Marcel Apfelbaum wrote:
>> Allow adding sysbus devices with -device on Q35.
>>
>> At first Q35 will support only intel-iommu to be added this way,
>> however the command line will support all sysbus devices.
>>
>> Mark with 'cannot_instantiate_with_device_add_yet' the ones
>> causing immediate problems (e.g. crashes).
>
> What happens if we do dynamic device_add for IOMMU? Guessing we should
> not allow that as well?
>
Sure, hot-plug is not supported, at least for now.
I can think about a device that has an IOMMU built-in,
but this is not our use-case.
Thanks,
Marcel
> -- peterx
>
prev parent reply other threads:[~2016-06-08 11:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 20:15 [Qemu-devel] [PATCH v2 0/3] enable iommu with -device Marcel Apfelbaum
2016-06-02 20:15 ` [Qemu-devel] [PATCH v2 1/3] hw/pci: delay bus_master_enable_region initialization Marcel Apfelbaum
2016-06-08 11:16 ` Paolo Bonzini
2016-06-08 11:36 ` Marcel Apfelbaum
2016-06-02 20:15 ` [Qemu-devel] [PATCH v2 2/3] hw/iommu: enable iommu with -device Marcel Apfelbaum
2016-06-03 16:07 ` Michael S. Tsirkin
2016-06-05 8:46 ` Marcel Apfelbaum
2016-06-05 9:59 ` Michael S. Tsirkin
2016-06-05 10:21 ` Marcel Apfelbaum
2016-06-12 4:27 ` Peter Xu
2016-06-13 10:20 ` Marcel Apfelbaum
2016-06-13 13:04 ` Peter Xu
2016-06-02 20:15 ` [Qemu-devel] [PATCH v2 3/3] q35: allow dynamic sysbus Marcel Apfelbaum
2016-06-03 6:33 ` Markus Armbruster
2016-06-03 6:47 ` Marcel Apfelbaum
2016-06-08 2:56 ` Peter Xu
2016-06-08 11:18 ` Marcel Apfelbaum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5757FF22.3090209@gmail.com \
--to=marcel.apfelbaum@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=bd.aviv@gmail.com \
--cc=davidkiarie4@gmail.com \
--cc=ehabkost@redhat.com \
--cc=jan.kiszka@web.de \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).