From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58803)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1bAbVq-00067H-Lo
	for qemu-devel@nongnu.org; Wed, 08 Jun 2016 07:19:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1bAbVm-0005Sn-EI
	for qemu-devel@nongnu.org; Wed, 08 Jun 2016 07:19:05 -0400
Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:33314)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1bAbVm-0005S6-6O
	for qemu-devel@nongnu.org; Wed, 08 Jun 2016 07:19:02 -0400
Received: by mail-wm0-x242.google.com with SMTP id r5so2160110wmr.0
	for <qemu-devel@nongnu.org>; Wed, 08 Jun 2016 04:19:01 -0700 (PDT)
Reply-To: marcel@redhat.com
References: <1464898555-14914-1-git-send-email-marcel@redhat.com>
	<1464898555-14914-4-git-send-email-marcel@redhat.com>
	<20160608025645.GJ1039@pxdev.xzpeter.org>
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Message-ID: <5757FF22.3090209@gmail.com>
Date: Wed, 8 Jun 2016 14:18:58 +0300
MIME-Version: 1.0
In-Reply-To: <20160608025645.GJ1039@pxdev.xzpeter.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 3/3] q35: allow dynamic sysbus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Xu <peterx@redhat.com>, Marcel Apfelbaum <marcel@redhat.com>
Cc: ehabkost@redhat.com, mst@redhat.com, bd.aviv@gmail.com, qemu-devel@nongnu.org, alex.williamson@redhat.com, jan.kiszka@web.de, pbonzini@redhat.com, davidkiarie4@gmail.com

On 06/08/2016 05:56 AM, Peter Xu wrote:
> On Thu, Jun 02, 2016 at 11:15:55PM +0300, Marcel Apfelbaum wrote:
>> Allow adding sysbus devices with -device on Q35.
>>
>> At first Q35 will support only intel-iommu to be added this way,
>> however the command line will support all sysbus devices.
>>
>> Mark with 'cannot_instantiate_with_device_add_yet' the ones
>> causing immediate problems (e.g. crashes).
>
> What happens if we do dynamic device_add for IOMMU? Guessing we should
> not allow that as well?
>

Sure, hot-plug is not supported, at least for now.
I can think about a device that has an IOMMU built-in,
but this is not our use-case.

Thanks,
Marcel


> -- peterx
>