From: "Denis V. Lunev" <den@openvz.org>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io
Date: Wed, 8 Jun 2016 14:31:02 +0300 [thread overview]
Message-ID: <575801F6.8060505@openvz.org> (raw)
In-Reply-To: <20160608112357.GD5324@noname.str.redhat.com>
On 06/08/2016 02:23 PM, Kevin Wolf wrote:
> Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben:
>> From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>
>> Acquire aio context before run command, this is mandatory for unit tests.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Kevin Wolf <kwolf@redhat.com>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
> Looks right to me, but why "mandatory for unit tests"? Does this fix an
> observable bug in unit tests? If so, we should be more specific in the
> commit message.
>
> But in fact, I would only expect it to make a difference for dataplane
> and I don't think we have test cases that use both the 'qemu-io' HMP
> command and dataplane.
>
> Kevin
we have failures in backup test, where dirty bitmap is protected with
aio_context_acquire. This test is not committed yet, but present in the
mail list.
As far as I know this command is used mostly for tests thus I have
written commit message this way. This change is separate and I think
definitely right.
Den
next prev parent reply other threads:[~2016-06-08 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 9:39 [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io Denis V. Lunev
2016-06-08 11:23 ` Kevin Wolf
2016-06-08 11:31 ` Denis V. Lunev [this message]
2016-06-14 8:34 ` Denis V. Lunev
2016-06-14 8:44 ` Kevin Wolf
2016-06-14 9:00 ` Denis V. Lunev
2016-06-15 20:31 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575801F6.8060505@openvz.org \
--to=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).