From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33161)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bAbhb-0004m1-HF
	for qemu-devel@nongnu.org; Wed, 08 Jun 2016 07:31:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bAbhW-0000Wm-Fy
	for qemu-devel@nongnu.org; Wed, 08 Jun 2016 07:31:15 -0400
Received: from mail-db3on0140.outbound.protection.outlook.com
	([157.55.234.140]:46777
	helo=emea01-db3-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bAbhV-0000W2-JW
	for qemu-devel@nongnu.org; Wed, 08 Jun 2016 07:31:10 -0400
References: <1465378757-15271-1-git-send-email-den@openvz.org>
	<20160608112357.GD5324@noname.str.redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <575801F6.8060505@openvz.org>
Date: Wed, 8 Jun 2016 14:31:02 +0300
MIME-Version: 1.0
In-Reply-To: <20160608112357.GD5324@noname.str.redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, Paolo Bonzini <pbonzini@redhat.com>

On 06/08/2016 02:23 PM, Kevin Wolf wrote:
> Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben:
>> From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>
>> Acquire aio context before run command, this is mandatory for unit tests.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Kevin Wolf <kwolf@redhat.com>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
> Looks right to me, but why "mandatory for unit tests"? Does this fix an
> observable bug in unit tests? If so, we should be more specific in the
> commit message.
>
> But in fact, I would only expect it to make a difference for dataplane
> and I don't think we have test cases that use both the 'qemu-io' HMP
> command and dataplane.
>
> Kevin
we have failures in backup test, where dirty bitmap is protected with
aio_context_acquire. This test is not committed yet, but present in the
mail list.

As far as I know this command is used mostly for tests thus I have
written commit message this way. This change is separate and I think
definitely right.

Den