From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAddY-00007S-Am for qemu-devel@nongnu.org; Wed, 08 Jun 2016 09:35:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAddT-0006W9-F5 for qemu-devel@nongnu.org; Wed, 08 Jun 2016 09:35:12 -0400 References: <1465382576-25552-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <57581F08.9080508@redhat.com> Date: Wed, 8 Jun 2016 07:35:04 -0600 MIME-Version: 1.0 In-Reply-To: <1465382576-25552-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K55DsTq4DUvOPxTrnpiag5OR4ScElTEgO" Subject: Re: [Qemu-devel] [PATCH] ui: fix regression in printing VNC host/port on startup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, qemu-stable@nongnu.org, "Dr. David Alan Gilbert" , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --K55DsTq4DUvOPxTrnpiag5OR4ScElTEgO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/08/2016 04:42 AM, Daniel P. Berrange wrote: > If VNC is chosen as the compile time default display backend, > QEMU will print the host/port it listens on at startup. > Previously this would look like >=20 > VNC server running on '::1:5900' >=20 > but in 04d2529da27db512dcbd5e99d0e26d333f16efcc the ':' was > accidentally replaced with a ';'. This the ':' back. >=20 > Reported-by: Dr. David Alan Gilbert > Signed-off-by: Daniel P. Berrange > --- > ui/vnc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/ui/vnc.c b/ui/vnc.c > index c862fdc..75ae2a7 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -3225,7 +3225,7 @@ char *vnc_display_local_addr(const char *id) > qapi_free_SocketAddress(addr); > return NULL; > } > - ret =3D g_strdup_printf("%s;%s", addr->u.inet.data->host, > + ret =3D g_strdup_printf("%s:%s", addr->u.inet.data->host, > addr->u.inet.data->port); > qapi_free_SocketAddress(addr); > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --K55DsTq4DUvOPxTrnpiag5OR4ScElTEgO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXWB8IAAoJEKeha0olJ0Nq7hQH+gN3ipHvpDsym1OarGA+OjNr 5g4UG17VjVn8uTNrKUQXhsNaOvzGcMDbKN+Q4WX5MAStg/FiTgEg9xe9SfzHYCbk RAaRs4C9wjjHiQlwL9i9PEa6XOPkG4JlulUJ1LrWL5y7kFVIarTSHp6IcUvzPxS9 nnv2uNseqDZhckV0D2ooRBFxYu3Olz0Kjio9LKRf9eL8p0NOhVmQWTeChR73Hr5e DBAzFD9KS8y1ZfSLAyibnB5sQKxOdh8S/kh1U+58Qkl0q+Th+Tt5A+C83k5jwKsD G+NleAwxh9MeDYIHwvKn1Uzf8cly/TqEcSE+L8e7GdrMlQj1/fB4Iusre8Kw/lQ= =QwuW -----END PGP SIGNATURE----- --K55DsTq4DUvOPxTrnpiag5OR4ScElTEgO--