From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAe6x-0003NR-63 for qemu-devel@nongnu.org; Wed, 08 Jun 2016 10:05:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAe6r-0006Wy-UF for qemu-devel@nongnu.org; Wed, 08 Jun 2016 10:05:34 -0400 References: <1463404220-5945-1-git-send-email-sw@weilnetz.de> From: Eric Blake Message-ID: <57582628.9060306@redhat.com> Date: Wed, 8 Jun 2016 08:05:28 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UPTpQpLd93UBfBP2v4xhhaLeiWaMqUSiN" Subject: Re: [Qemu-devel] [PATCH] configure: Use $(..) instead of deprecated `..` List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Maciej W. Rozycki" , Stefan Weil Cc: QEMU Trivial , QEMU Developer This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UPTpQpLd93UBfBP2v4xhhaLeiWaMqUSiN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/08/2016 06:16 AM, Maciej W. Rozycki wrote: > On Mon, 16 May 2016, Stefan Weil wrote: >=20 >> This fixes these warnings from shellcheck: >> >> ^-- SC2006: Use $(..) instead of deprecated `..` >> >> Signed-off-by: Stefan Weil >> --- >> >> More warnings from shellcheck for configure and other files >> will be handled by later patches. >=20 > Unlike `..` the $(..) Bourne shell construct is not fully portable, so= me=20 > implementations do not recognise it. All POSIX implementations support it. The only shell that doesn't is from Solaris /bin/sh, and that pre-dates modern OpenSolaris which has (finally) modernized their shell. And I don't think we have anyone actively trying to build qemu for Solaris (we have bug reports for mingw, BSD, and Mac OS, but I haven't seen anyone complaining about a failed Solaris build). > So what's the technical justification -- beyond shutting up some rando= m=20 > checker tool -- for making this change? Does the benefit recognised in= =20 > making this change outweigh the limitation introduced? How about handl= ing=20 > failures properly? We already have places where we assume a POSIX shell, and $() is cleaner to use than `` when it comes to nesting quotes. > NB given the above, and especially because of the introduced functiona= l=20 > regression mentioned, I don't think this change qualifies as trivial. I agree that calling this trivial may be a stretch, but I see no problem with the patch itself if the commit message is beefed up to provide more justification than just "silence a lint-like tool". --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UPTpQpLd93UBfBP2v4xhhaLeiWaMqUSiN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXWCYoAAoJEKeha0olJ0NqaagH/3Ef/1SrQEx+ZQh7I6tQRI91 02JlrASbNO8WS4PvlVy1P7EL0srNmBZUhPBmiGFrKi9TTVvHsMe4wXGRiHCH+DF4 V06pFEWBNEkq8rUaM/B8hC/jynvM5Wlh4RAc3+0KKHx8GRvSp1loKkNfyJVw8Q3i 4F3RbIg4A3HRuH7nC9o+14qYnJwujZKZ+YNYbQIK8WDfVL2obtl8Qde6U+OUHREK B+lhR0/x24phVKgrYB3zdrLPo95tCor9Ji2n5EhgnwgY2a2kgMvgYolyYaeKzVRH nc/vN0xe+VZOX0I0YmZEQsrLMhZ7O0UPm797Mgh/oxoLWCCrnrk24DVlHBaAdEQ= =a6VW -----END PGP SIGNATURE----- --UPTpQpLd93UBfBP2v4xhhaLeiWaMqUSiN--