From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAzvT-0000E0-KH for qemu-devel@nongnu.org; Thu, 09 Jun 2016 09:23:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAzvQ-0004p0-5t for qemu-devel@nongnu.org; Thu, 09 Jun 2016 09:23:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAzvP-0004ow-W0 for qemu-devel@nongnu.org; Thu, 09 Jun 2016 09:23:08 -0400 References: <1465145673-5315-1-git-send-email-davidkiarie4@gmail.com> <1465145673-5315-2-git-send-email-davidkiarie4@gmail.com> <20160607191239.GB18662@thinpad.lan.raisama.net> From: Marcel Apfelbaum Message-ID: <57596DB6.3080702@redhat.com> Date: Thu, 9 Jun 2016 16:23:02 +0300 MIME-Version: 1.0 In-Reply-To: <20160607191239.GB18662@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , David Kiarie Cc: qemu-devel@nongnu.org, imammedo@redhat.com, jasowang@redhat.com, mst@redhat.com, pbonzini@redhat.com, jan.kiszka@web.de, rkrcmar@redhat.com, alex.williamson@redhat.com, wexu@redhat.com, valentine.sinitsyn@gmail.com, peterx@redhat.com On 06/07/2016 10:12 PM, Eduardo Habkost wrote: > Hi, > [...] > [...] >> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c >> index 04aae89..431eaed 100644 >> --- a/hw/i386/pc_q35.c >> +++ b/hw/i386/pc_q35.c >> @@ -281,6 +281,7 @@ static void pc_q35_machine_options(MachineClass *m) >> m->default_machine_opts = "firmware=bios-256k.bin"; >> m->default_display = "std"; >> m->no_floppy = 1; >> + m->has_dynamic_sysbus = true; > > Why is this needed? Is it possible to do this change before > adding the iommu code? Can this be done in a separate patch that > documents why it should be changed and why it is safe to set it > to true? > >> Hi Eduardo, I also have this change as part of '[PATCH v2 0/3] enable iommu with -device'. Please see: https://www.mail-archive.com/qemu-devel@nongnu.org/msg374644.html Thanks, Marcel