From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bB2dg-0000CQ-Ig for qemu-devel@nongnu.org; Thu, 09 Jun 2016 12:17:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bB2db-0001aU-HR for qemu-devel@nongnu.org; Thu, 09 Jun 2016 12:16:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bB2db-0001aJ-9u for qemu-devel@nongnu.org; Thu, 09 Jun 2016 12:16:55 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A7F40BBF46 for ; Thu, 9 Jun 2016 16:16:54 +0000 (UTC) References: <1463632874-28559-1-git-send-email-eblake@redhat.com> <87vb1qxymw.fsf@dusky.pond.sub.org> From: Eric Blake Message-ID: <57599674.6090904@redhat.com> Date: Thu, 9 Jun 2016 10:16:52 -0600 MIME-Version: 1.0 In-Reply-To: <87vb1qxymw.fsf@dusky.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2ht2EE3cNVO1KIFVIlQv9dfOeJOWvt1ai" Subject: Re: [Qemu-devel] [PATCH v4 00/28] Add qapi-to-JSON and clone visitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2ht2EE3cNVO1KIFVIlQv9dfOeJOWvt1ai Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/03/2016 06:09 AM, Markus Armbruster wrote: > Most patches are ready as is or with minor touch-ups. >=20 > I'd probably drop PATCH 01. The file name collision no longer exists, > and moving files just to improve their names a bit doesn't seem worth > the bother. It's a bit more churn to the rest of the series, but I can live with it. It's also more related to the JSON visitor than the clone visitor, so even if I do want to keep it, it makes more sense to keep it with the second half of the series. >=20 > There are memory leaks in PATCH 12 and 24 (see review of PATCH 24). >=20 > PATCH 13 needs more work than I'm comfortable to do on commit. Mostly > missing comment updates, but also a crash bug. I've got that fix ready to post. >=20 > On PATCH 21, I have minor interface design doubts. >=20 > The only difficult question is what to do about invalid UTF-8 strings > and non-finite numbers. Patches before PATCH 29 show opinions, but a > decision isn't made until PATCH 29. Good, because it leaves most of > this series not blocked by the debate on what we should do. >=20 > I guess I could take PATCH 02-12 now, and let you respin the rest. But= > perhaps its easier if you respin all of them. I'm posting v5 of 2-15 now, then focusing on your comments on the JSON visitor for a later posting. I also think my subset F series (adding a 'box' parameter) is relatively orthogonal, if you want to start reviewing that: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg03569.html I'd still LOVE to get blockdev-add working for ALL block devices before 2.7 soft freeze (there's patches for NBD that I need to review, and I know the gluster folks were waiting on qapi patches to be able to use a SocketAddress union as the basis for the gluster branch of the blockdev-add union - and my qapi patches are almost all the way there to permitting it). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2ht2EE3cNVO1KIFVIlQv9dfOeJOWvt1ai Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXWZZ0AAoJEKeha0olJ0NqWPsH/1PDdmydu+nxJniCB+mUF0ul iO8eylzBIoxsDufe/hfBoFoujiuhtkjktau7F8oFytdKQ7SqAA8SI7mM8ZKZb4ju q1nvYcBYc8o5dn+HKNDWgimlaFErKTCtyjsFv5Y32FDSwYzxwwQJsHAnoOOuVyIy UVgED42vx7S91fdzyEDIYOObTqM10g8Buh/Auwb1Xj2welLM31Iu3gA2u6bldnRO CiYeax5y63XYgaE05D2DIbGgnr//Tx3IRAsDelCx/2FLcieVhkKAvdl2OeF8Z2bl Or6iMcfC8x49cp/im5CmyiJp0rd87Xd3KV9+dqlkNnebXNoFk9zwCqFYAu+rK0I= =/XU8 -----END PGP SIGNATURE----- --2ht2EE3cNVO1KIFVIlQv9dfOeJOWvt1ai--