From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBRtm-0001Du-Cg for qemu-devel@nongnu.org; Fri, 10 Jun 2016 15:15:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBRti-0004zX-3u for qemu-devel@nongnu.org; Fri, 10 Jun 2016 15:15:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBRth-0004zK-UO for qemu-devel@nongnu.org; Fri, 10 Jun 2016 15:15:14 -0400 References: <1465574962-2710-1-git-send-email-peter.maydell@linaro.org> From: Eric Blake Message-ID: <575B11C0.4000901@redhat.com> Date: Fri, 10 Jun 2016 13:15:12 -0600 MIME-Version: 1.0 In-Reply-To: <1465574962-2710-1-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V9QENnsLQDfKtLdWnSGSugB73Qj06L9or" Subject: Re: [Qemu-devel] [PATCH v2] migration: Don't use *_to_cpup() and cpu_to_*w() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org, Juan Quintela , Amit Shah This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V9QENnsLQDfKtLdWnSGSugB73Qj06L9or Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/10/2016 10:09 AM, Peter Maydell wrote: > The *_to_cpup() and cpu_to_*w() functions just compose a pointer > dereference with a byteswap. Instead use ld*_p() and st*_p(), > which handle potential pointer misalignment and avoid the need > to cast the pointer. >=20 > Signed-off-by: Peter Maydell > --- > Changes v1->v2: fix cpu_to_*w() uses too. >=20 > The motivation here is that I'd like to get rid of _to_cpup() > and cpu_to_*w() entirely: we don't have many places that use them. > --- > migration/migration.c | 12 ++++++------ > migration/savevm.c | 4 ++-- > 2 files changed, 8 insertions(+), 8 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --V9QENnsLQDfKtLdWnSGSugB73Qj06L9or Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXWxHAAAoJEKeha0olJ0Nq0dYIAJG3vaNSm2ucYW1VUpooQibG 2FcQatY5+KfZxXBPTATkMSdR7Rj+kNBdeyAwcc+Tq7CqoZMvEN+X7pK1GYH9d8Cw v5S9JIRpbEWMGuDsXglegHLC5twxU6P77D/bLJzHIjrA49SrV0ZmbmwXYZHsQdii B8ZouEKBVUSnWhhiN04dCf8dyq0Eja4vlQqf+ZM8rylLN71iK3JMc3kha30wZMMg XkaiYwVjEaBLI9fYNHMHdnzCrK6j32QUYUdrWN71buuepkMoAU9qyM2/6NqqWMk5 ySSuRFgwNrkxnTB+MVQkjECbfXYLguAr6NDmCBfglHZijookFRTL9JcdEc0CoBI= =HDbU -----END PGP SIGNATURE----- --V9QENnsLQDfKtLdWnSGSugB73Qj06L9or--