Re: [Qemu-devel] [PATCH 6/6] block: Remove bs->zero_beyond_eof

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

On 06/10/2016 10:05 AM, Kevin Wolf wrote:
> It is always true for open images now.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block.c                   |  2 --
>  block/io.c                | 51 +++++++++++++++++++++--------------------------
>  include/block/block_int.h |  3 ---
>  3 files changed, 23 insertions(+), 33 deletions(-)
> 

> +++ b/block/io.c
> @@ -1000,40 +1000,35 @@ static int coroutine_fn bdrv_aligned_preadv(BlockDriverState *bs,
>      }
>  
>      /* Forward the request to the BlockDriver */
> -    if (!bs->zero_beyond_eof) {
> -        ret = bdrv_driver_preadv(bs, offset, bytes, qiov, 0);
> -    } else {
> -        /* Read zeros after EOF */
> -        int64_t total_bytes, max_bytes;
> +    int64_t total_bytes, max_bytes;

This declaration is now in the middle of the function.  Shouldn't you
hoist it to the beginning?

That's minor enough to fix on pull request, so:
Reviewed-by: Eric Blake <eblake@redhat.com>

I'll rebase my pending byte-based BlockLimits series on top of this.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]