[Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet"

[Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet"

[Sean Bruno]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512



- --quiet isn't available on FreeBSD and doesn't seem to be used in
other places.  This fixes some non-fatal build errors on FreeBSD.  The
use of "-s" over "--quiet" seems to be the preferred use in the Makefile.

diff --git a/Makefile b/Makefile
index ed4032a..a7a356a 100644
- --- a/Makefile
+++ b/Makefile
@@ -185,7 +185,7 @@ qemu-version.h: FORCE
                                printf '""\n'; \
                        fi; \
                fi) > $@.tmp)
- -       $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
+       $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)

 config-host.h: config-host.h-timestamp
 config-host.h-timestamp: config-host.mak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQF8BAEBCgBmBQJXXEcgXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx
MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kpWgIAI/ZzRYWUWNYXF9D8NuvPlub
Arh2F7qBBvukaMra5fVQwJcNji82WdEHmClsV5782rPM19LC7QVqiiga494WFbQ2
mGWVJF0w9w0dA0lCz65mlWwqX0U/u0No8Z/RMoBtublTvbHtLfy/OUAMJrV940X2
EbPu0x/0vBlUCfgf2KUNcs6O6lt9AUJFvrSzeTJgLNHml7hchyHVMQujMv/2YggH
4TscRWswBcmikP8Rorxf59mBQx/om2n3omgnWxlAuvrgqm0ief42pYYkyIqTaPr0
C1dubmrV8ArcMWlGStUAhV2W1ibsph3ZSgoUuHqkpv5iz5BFizIqS+EvWfo1OBM=
=x1ai
-----END PGP SIGNATURE-----

Re: [Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet"

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

On 06/11/2016 11:15 AM, Sean Bruno wrote:
> 
> 
> --quiet isn't available on FreeBSD and doesn't seem to be used in
> other places.  This fixes some non-fatal build errors on FreeBSD.  The
> use of "-s" over "--quiet" seems to be the preferred use in the Makefile.
> 
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
>                                 printf '""\n'; \
>                         fi; \
>                 fi) > $@.tmp)
> -       $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> +       $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet"

[Peter Maydell]

On 11 June 2016 at 18:15, Sean Bruno <sbruno@freebsd.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
>
>
> - --quiet isn't available on FreeBSD and doesn't seem to be used in
> other places.  This fixes some non-fatal build errors on FreeBSD.  The
> use of "-s" over "--quiet" seems to be the preferred use in the Makefile.
>
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> - --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
>                                 printf '""\n'; \
>                         fi; \
>                 fi) > $@.tmp)
> - -       $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> +       $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
>
>  config-host.h: config-host.h-timestamp
>  config-host.h-timestamp: config-host.mak

Can you provide a Signed-off-by: for this patch, please?
We can't apply it without one.

(Providing it as a patch in the usual git format with
commit message would also be nice, but optional.)

thanks
-- PMM