From: Eric Blake <eblake@redhat.com>
To: Sean Bruno <sbruno@freebsd.org>, QEMU Developers <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, famz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet"
Date: Sat, 11 Jun 2016 14:42:48 -0600 [thread overview]
Message-ID: <575C77C8.7000200@redhat.com> (raw)
In-Reply-To: <575C4724.6030707@freebsd.org>
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
On 06/11/2016 11:15 AM, Sean Bruno wrote:
>
>
> --quiet isn't available on FreeBSD and doesn't seem to be used in
> other places. This fixes some non-fatal build errors on FreeBSD. The
> use of "-s" over "--quiet" seems to be the preferred use in the Makefile.
>
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
> printf '""\n'; \
> fi; \
> fi) > $@.tmp)
> - $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> + $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-11 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 17:15 [Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet" Sean Bruno
2016-06-11 20:42 ` Eric Blake [this message]
2016-06-12 22:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575C77C8.7000200@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sbruno@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).