From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59606)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bBpk7-0006sR-64
	for qemu-devel@nongnu.org; Sat, 11 Jun 2016 16:42:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bBpk3-0005iK-12
	for qemu-devel@nongnu.org; Sat, 11 Jun 2016 16:42:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35160)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bBpk2-0005he-Ra
	for qemu-devel@nongnu.org; Sat, 11 Jun 2016 16:42:50 -0400
References: <575C4724.6030707@freebsd.org>
From: Eric Blake <eblake@redhat.com>
Message-ID: <575C77C8.7000200@redhat.com>
Date: Sat, 11 Jun 2016 14:42:48 -0600
MIME-Version: 1.0
In-Reply-To: <575C4724.6030707@freebsd.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="MRMJJS5IPOMQRaTJf5G7ecMpsKGaUWidp"
Subject: Re: [Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sean Bruno <sbruno@freebsd.org>, QEMU Developers <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, famz@redhat.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--MRMJJS5IPOMQRaTJf5G7ecMpsKGaUWidp
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/11/2016 11:15 AM, Sean Bruno wrote:
>=20
>=20
> --quiet isn't available on FreeBSD and doesn't seem to be used in
> other places.  This fixes some non-fatal build errors on FreeBSD.  The
> use of "-s" over "--quiet" seems to be the preferred use in the Makefil=
e.
>=20
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
>                                 printf '""\n'; \
>                         fi; \
>                 fi) > $@.tmp)
> -       $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> +       $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)

Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--MRMJJS5IPOMQRaTJf5G7ecMpsKGaUWidp
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJXXHfIAAoJEKeha0olJ0Nq0+sH/jdSIFpbzLgT/VzLolgFYfUm
5Lf4efTMNrozgzhmktuvLGHHkiyovoUw8HI1lieP5jGHy3Qq7owI2PQrt3lEi7il
7XIGrLhFZTVoLbB7ioWJrLznVIxOI7pXwcRL3rhwM5bgFzK0ensMqGnLb4DJGs5t
84rdr9/PdxnRw/gMTMh9uTCZXjTta2FdhoRhqnTK+w0L5fdVMa+rHAf/SB6FP9sf
FN0CeXk4aEX8KWm3/CurYc+atKlrrtEQMQOVE9Zo5gRTZjhe2uYyXbqUh6yTgEU2
8hRBypo9agCBzstMeM8CcT8XIkJOXYeLgpvy4Trtp2Pk7GUaMjzh3v4fnnhL9F4=
=R1wc
-----END PGP SIGNATURE-----

--MRMJJS5IPOMQRaTJf5G7ecMpsKGaUWidp--