* [Qemu-devel] [PATCH V3] net: fix qemu_announce_self not emitting packets
@ 2016-06-09 9:39 Peter Lieven
2016-06-13 2:56 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Peter Lieven @ 2016-06-09 9:39 UTC (permalink / raw)
To: qemu-devel
Cc: jasowang, s.priebe, pbonzini, Peter Lieven, qemu-stable,
hongyang.yang
commit fefe2a78 accidently dropped the code path for injecting
raw packets. This feature is needed for sending gratuitous ARPs
after an incoming migration has completed. The result is increased
network downtime for vservers where the network card is not virtio-net
with the VIRTIO_NET_F_GUEST_ANNOUNCE feature.
Fixes: fefe2a78abde932e0f340b21bded2c86def1d242
Cc: qemu-stable@nongnu.org
Cc: hongyang.yang@easystack.cn
Signed-off-by: Peter Lieven <pl@kamp.de>
---
v1->v2: assert that only raw packets with a plain buffer come in. [Paolo]
v2->v3: nc_senv_compat can take care of raw packets [Paolo, Jason]
net/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index 5f3e5a9..75bb177 100644
--- a/net/net.c
+++ b/net/net.c
@@ -722,7 +722,7 @@ ssize_t qemu_deliver_packet_iov(NetClientState *sender,
return 0;
}
- if (nc->info->receive_iov) {
+ if (nc->info->receive_iov && !(flags & QEMU_NET_PACKET_FLAG_RAW)) {
ret = nc->info->receive_iov(nc, iov, iovcnt);
} else {
ret = nc_sendv_compat(nc, iov, iovcnt, flags);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH V3] net: fix qemu_announce_self not emitting packets
2016-06-09 9:39 [Qemu-devel] [PATCH V3] net: fix qemu_announce_self not emitting packets Peter Lieven
@ 2016-06-13 2:56 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2016-06-13 2:56 UTC (permalink / raw)
To: Peter Lieven, qemu-devel; +Cc: s.priebe, pbonzini, qemu-stable, hongyang.yang
On 2016年06月09日 17:39, Peter Lieven wrote:
> commit fefe2a78 accidently dropped the code path for injecting
> raw packets. This feature is needed for sending gratuitous ARPs
> after an incoming migration has completed. The result is increased
> network downtime for vservers where the network card is not virtio-net
> with the VIRTIO_NET_F_GUEST_ANNOUNCE feature.
>
> Fixes: fefe2a78abde932e0f340b21bded2c86def1d242
> Cc: qemu-stable@nongnu.org
> Cc: hongyang.yang@easystack.cn
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> v1->v2: assert that only raw packets with a plain buffer come in. [Paolo]
> v2->v3: nc_senv_compat can take care of raw packets [Paolo, Jason]
>
> net/net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/net.c b/net/net.c
> index 5f3e5a9..75bb177 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -722,7 +722,7 @@ ssize_t qemu_deliver_packet_iov(NetClientState *sender,
> return 0;
> }
>
> - if (nc->info->receive_iov) {
> + if (nc->info->receive_iov && !(flags & QEMU_NET_PACKET_FLAG_RAW)) {
> ret = nc->info->receive_iov(nc, iov, iovcnt);
> } else {
> ret = nc_sendv_compat(nc, iov, iovcnt, flags);
Applied to -net. Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-13 2:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-09 9:39 [Qemu-devel] [PATCH V3] net: fix qemu_announce_self not emitting packets Peter Lieven
2016-06-13 2:56 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).