From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCOyh-00089p-U8 for qemu-devel@nongnu.org; Mon, 13 Jun 2016 06:20:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCOyd-000229-Uf for qemu-devel@nongnu.org; Mon, 13 Jun 2016 06:20:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCOyd-000225-Pd for qemu-devel@nongnu.org; Mon, 13 Jun 2016 06:20:15 -0400 References: <1464898555-14914-1-git-send-email-marcel@redhat.com> <1464898555-14914-3-git-send-email-marcel@redhat.com> <20160612042754.GN1039@pxdev.xzpeter.org> From: Marcel Apfelbaum Message-ID: <575E88DB.2020603@redhat.com> Date: Mon, 13 Jun 2016 13:20:11 +0300 MIME-Version: 1.0 In-Reply-To: <20160612042754.GN1039@pxdev.xzpeter.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/3] hw/iommu: enable iommu with -device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, mst@redhat.com, pbonzini@redhat.com, ehabkost@redhat.com, davidkiarie4@gmail.com, jan.kiszka@web.de, bd.aviv@gmail.com, alex.williamson@redhat.com On 06/12/2016 07:27 AM, Peter Xu wrote: > On Thu, Jun 02, 2016 at 11:15:54PM +0300, Marcel Apfelbaum wrote: > > [...] > >> static void vtd_realize(DeviceState *dev, Error **errp) >> { >> + PCIBus *bus = PC_MACHINE(qdev_get_machine())->bus; >> IntelIOMMUState *s = INTEL_IOMMU_DEVICE(dev); >> >> VTD_DPRINTF(GENERAL, ""); >> @@ -2029,6 +2043,9 @@ static void vtd_realize(DeviceState *dev, Error **errp) >> s->vtd_as_by_busptr = g_hash_table_new_full(vtd_uint64_hash, vtd_uint64_equal, >> g_free, g_free); >> vtd_init(s); >> + sysbus_mmio_map(SYS_BUS_DEVICE(s), 0, Q35_HOST_BRIDGE_IOMMU_ADDR); >> + bus->iommu_fn = vtd_host_dma_iommu; >> + bus->iommu_opaque = dev; > > Here, shall we still use pci_setup_iommu() to keep the two fields > private for pci framework? > I've already spotted it and took care of it, thanks :) ! > Btw, I am rebasing Intel IR work onto this patchset, but encountered > issues (guest hang, or errornous interrupts) when guest specify more > than 1 vcpus (everything is cool as long as vcpu=1). Maybe there is > something wrong during the rebase, still investigating. Please shoot > if there is any clue. > I am running with 2 vcpus and I didn't see any problem, I'll let you know if can reproduce. Thanks, Marcel > Thanks, > > -- peterx >