From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53762)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1bCQJV-00062c-UX
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 07:45:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1bCQJQ-0005wJ-4r
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 07:45:52 -0400
Message-ID: <575E9BA9.5010307@huawei.com>
Date: Mon, 13 Jun 2016 19:40:25 +0800
From: Shannon Zhao <zhaoshenglong@huawei.com>
MIME-Version: 1.0
References: <1464274540-19693-1-git-send-email-peter.maydell@linaro.org>
	<1464274540-19693-21-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1464274540-19693-21-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 20/22] target-arm/monitor.c: Advertise
 emulated GICv3 in capabilities
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org, Shlomo Pongratz <shlomo.pongratz@huawei.com>, Shlomo Pongratz <shlomopongratz@gmail.com>, Pavel Fedin <p.fedin@samsung.com>, Shannon Zhao <shannon.zhao@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>



On 2016/5/26 22:55, Peter Maydell wrote:
> Now we have an emulated GICv3 we should advertise it via the
> capabilities in the monitor protocol.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org>

> ---
>  target-arm/monitor.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/target-arm/monitor.c b/target-arm/monitor.c
> index 1ee59a2..299cb80 100644
> --- a/target-arm/monitor.c
> +++ b/target-arm/monitor.c
> @@ -72,8 +72,7 @@ GICCapabilityList *qmp_query_gic_capabilities(Error **errp)
>      GICCapability *v2 = gic_cap_new(2), *v3 = gic_cap_new(3);
>  
>      v2->emulated = true;
> -    /* TODO: we'd change to true after we get emulated GICv3. */
> -    v3->emulated = false;
> +    v3->emulated = true;
>  
>      gic_cap_kvm_probe(v2, v3);
>  
> 

-- 
Shannon