From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCQsD-0002O8-V6 for qemu-devel@nongnu.org; Mon, 13 Jun 2016 08:21:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCQsB-0005cP-Qm for qemu-devel@nongnu.org; Mon, 13 Jun 2016 08:21:44 -0400 References: <1463006384-7734-1-git-send-email-eblake@redhat.com> <1463006384-7734-3-git-send-email-eblake@redhat.com> <66590e5c-db93-1115-b9e1-a2647702e4e4@redhat.com> From: Eric Blake Message-ID: <575EA551.8000106@redhat.com> Date: Mon, 13 Jun 2016 06:21:37 -0600 MIME-Version: 1.0 In-Reply-To: <66590e5c-db93-1115-b9e1-a2647702e4e4@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="snRrww95EKppr848DeNqfnauGxwwFRoSt" Subject: Re: [Qemu-devel] [PATCH v4 02/11] nbd: More debug typo fixes, use correct formats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, alex@alex.org.uk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --snRrww95EKppr848DeNqfnauGxwwFRoSt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2016 06:04 AM, Paolo Bonzini wrote: >=20 >=20 > On 12/05/2016 00:39, Eric Blake wrote: >> Clean up some debug message oddities missed earlier; this includes >> some typos, and recognizing that %d is not necessarily compatible >> with uint32_t. >=20 > Actually it should be on any POSIX platform, since (by way of the > requirements on limits.h) POSIX requires sizeof(int) to be >=3D 4. Not quite true. On 32-bit platforms, uint32_t can be 'long' rather than 'int' (I think 32-bit cygwin used to be in this camp, once - I don't remember if it is still the case). Thus, PRId32 is NOT necessarily "d" on all platforms. >=20 > I will apply the patch, but fully expect this to bitrot... >=20 > Paolo >=20 >> Also add a couple messages that I found useful >> while debugging things. >> >> Signed-off-by: Eric Blake >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --snRrww95EKppr848DeNqfnauGxwwFRoSt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXXqVRAAoJEKeha0olJ0Nq0PwH/1DDLyVjvE9owo3dIJhCRdHa WUVs4Nbd73fl9h4mniu+dPL8nNd7D8o2U12zeXfZTRWTxEdWM9s9SpXlW1bDNAMG OozF7o58LCt9IxQRZvMFATLq20ZpQiqztjgzS+liVn7rRov6G7pZNRkIdceoQftt dcoktuTygb7ttZg7+vQBSHWGbDkPYHOwbA6OXBG9e4HzPk2NxS5G1xDHXm02nOxj vpWtr1ZUn3YxriTIgJ+Hfgvy1cHLVsy0UHlOF69dSOowp9D3vv1eHcMEOeewIMWD FyJZPZnytBfAjIfz144JIYgG9WGC2SWjyvSEznaxXv7vLoKcwyrVMS9PQsKFE3E= =0Xbq -----END PGP SIGNATURE----- --snRrww95EKppr848DeNqfnauGxwwFRoSt--