From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH] nbd: simplify the nbd_request and nbd_reply structs
Date: Mon, 13 Jun 2016 06:27:13 -0600 [thread overview]
Message-ID: <575EA6A1.6090003@redhat.com> (raw)
In-Reply-To: <1465810982-10191-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On 06/13/2016 03:43 AM, Paolo Bonzini wrote:
> These structs are never used to represent the bytes that go over the
> network. The big-endian network data is built into a uint8_t array
> in nbd_{receive,send}_{request,reply}. Remove the unused magic field,
> reorder the struct to avoid holes, and remove the packed attribute.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> include/block/nbd.h | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2016-06-13 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 9:43 [Qemu-devel] [PATCH] nbd: simplify the nbd_request and nbd_reply structs Paolo Bonzini
2016-06-13 12:27 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575EA6A1.6090003@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).