From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCQxc-00078I-M3 for qemu-devel@nongnu.org; Mon, 13 Jun 2016 08:27:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCQxW-0006sL-Sa for qemu-devel@nongnu.org; Mon, 13 Jun 2016 08:27:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCQxW-0006sH-Ml for qemu-devel@nongnu.org; Mon, 13 Jun 2016 08:27:14 -0400 References: <1465810982-10191-1-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <575EA6A1.6090003@redhat.com> Date: Mon, 13 Jun 2016 06:27:13 -0600 MIME-Version: 1.0 In-Reply-To: <1465810982-10191-1-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TvscEqAT47jsXLjgCjrWjXltsW0b7FICs" Subject: Re: [Qemu-devel] [PATCH] nbd: simplify the nbd_request and nbd_reply structs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TvscEqAT47jsXLjgCjrWjXltsW0b7FICs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2016 03:43 AM, Paolo Bonzini wrote: > These structs are never used to represent the bytes that go over the > network. The big-endian network data is built into a uint8_t array > in nbd_{receive,send}_{request,reply}. Remove the unused magic field, > reorder the struct to avoid holes, and remove the packed attribute. >=20 > Signed-off-by: Paolo Bonzini > --- > include/block/nbd.h | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TvscEqAT47jsXLjgCjrWjXltsW0b7FICs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXXqahAAoJEKeha0olJ0NqVcEH/0JtsMwNydKS54Gtpm4qrP+G pn9EByIwCsKcUI5bHJ9PmPsW+rSauR2EWOCtr7kNH7rgN+/bEQDfwCfC7vP6R0tT 3uNwPAV/3tazB8DQJkSwWM4MJKkyowwoTp9HMpYLifF03NDVqT4C89mqU7velm4x IQMsPK7RPwecQ6eop+AOwT6j0+/PewZrqOtVyit9MRdy6Pvh2rCRa1TZiEs/Ot3y 0tNn1T9sllkjAEARdfyEUkHp3/+MQNQaY/1bcdBwYhrtPoms8kJ3sJdLjafCQHX4 Or34xYlHSc6p3ojZJcKD7w+pfGe8X9SO3yvfX+tYwYRY9h8VhnlvwVsI7RdYW6g= =uhz3 -----END PGP SIGNATURE----- --TvscEqAT47jsXLjgCjrWjXltsW0b7FICs--