From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCR6F-0005bV-DY for qemu-devel@nongnu.org; Mon, 13 Jun 2016 08:36:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCR6D-0000dy-Ez for qemu-devel@nongnu.org; Mon, 13 Jun 2016 08:36:14 -0400 References: <1465574722-27656-1-git-send-email-kwolf@redhat.com> <1465574722-27656-6-git-send-email-kwolf@redhat.com> <575B41A1.5030702@redhat.com> <20160612025802.GD27167@ad.usersys.redhat.com> From: Eric Blake Message-ID: <575EA8B4.7080908@redhat.com> Date: Mon, 13 Jun 2016 06:36:04 -0600 MIME-Version: 1.0 In-Reply-To: <20160612025802.GD27167@ad.usersys.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nw9bFDmtull1USnh8t8Cni1PtWm7RDnNR" Subject: Re: [Qemu-devel] [PATCH 5/6] qcow2: Let vmstate call qcow2_co_preadv/pwrite directly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-block@nongnu.org, mreitz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nw9bFDmtull1USnh8t8Cni1PtWm7RDnNR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/11/2016 08:58 PM, Fam Zheng wrote: >>> - return ret; >>> + return bs->drv->bdrv_co_pwritev(bs, qcow2_vm_state_offset(s) + p= os, >>> + qiov->size, qiov, 0); >>> } >> >> bs->drv->bdrv_co_pwritev() is an optional interface; not all the drive= rs >> have it yet. Should you be asserting that it exists, and/or returning= >> an error if it does not? >=20 > bs->drv is always qcow2 driver here so this is correct. In that case, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nw9bFDmtull1USnh8t8Cni1PtWm7RDnNR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXXqi0AAoJEKeha0olJ0NqFGIIAIyk80JVzffG5MpcawBbIh5l rkjmJpyB2W9F+qX/qWmvWE7a3+qDjAfoGVrv+0G2YZEBtzPrS+ynspMXvQbT9AI/ tKRHRi4xlo1JI5FIIycstT4SI9tjvjCFG98eze7DvJ9oilPZjKBq+SKP1xLJ0aha BD5KJTdMcDYyreyXrUBQZxMpLYTPOdAdb1FlXo6pReL3wApxVVso+nNc3FmTtEfA f71IatzAxogU8stpR2HlhJ4IqJyftyQdsSTGVdBnaPTXJxOYlHG7PEFzSVk8T38g 5AErAa3kDuwmNkEpxwEpJkrODKWu9HhmpWUGM/Inhqz37ccCY+Lp1mMz/09Ejo4= =+oy7 -----END PGP SIGNATURE----- --nw9bFDmtull1USnh8t8Cni1PtWm7RDnNR--