From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCTmK-0003we-PT for qemu-devel@nongnu.org; Mon, 13 Jun 2016 11:27:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCTmG-00039c-DH for qemu-devel@nongnu.org; Mon, 13 Jun 2016 11:27:52 -0400 References: <1465805418-15906-1-git-send-email-thuth@redhat.com> From: Eric Blake Message-ID: <575ED0F2.2080900@redhat.com> Date: Mon, 13 Jun 2016 09:27:46 -0600 MIME-Version: 1.0 In-Reply-To: <1465805418-15906-1-git-send-email-thuth@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="57MpaOtX2hA2kGfr6Sxh18qGv8k6SQEBN" Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Use (unsigned long) typecasts when using "%lu" format string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --57MpaOtX2hA2kGfr6Sxh18qGv8k6SQEBN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2016 02:10 AM, Thomas Huth wrote: > Some source code analyzers like cppcheck spill out a warning if > the sign of the argument does not match the format string. >=20 > Ticket: https://bugs.launchpad.net/qemu/+bug/1589564 > Signed-off-by: Thomas Huth > --- > hw/scsi/scsi-disk.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c > index 1881969..36f8a85 100644 > --- a/hw/scsi/scsi-disk.c > +++ b/hw/scsi/scsi-disk.c > @@ -2060,13 +2060,13 @@ static int32_t scsi_disk_emulate_command(SCSIRe= quest *req, uint8_t *buf) > } > break; > case MODE_SELECT: > - DPRINTF("Mode Select(6) (len %lu)\n", (long)r->req.cmd.xfer); > + DPRINTF("Mode Select(6) (len %lu)\n", (unsigned long)r->req.cm= d.xfer); Why do we need a cast in the first place? r->req.cmd.xfer is size_t, so why not just "Mode Select(6) (len %zu)\n", r->req.cmd.xfer)? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --57MpaOtX2hA2kGfr6Sxh18qGv8k6SQEBN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXXtDzAAoJEKeha0olJ0NqnIMIAJTiw7DyCyIURqt5Es2yZOqQ xngf3FRMuK3Z73kx0re+pSD7DejUU5EzJPuAGXrCEFN5/pQQdEAf7sCG8awhHuHW isU0g5wNTnMplzO3b1lTaDtMhP4o0oWJ0btg7kBj/LMt4fWSbTq80Dlzw2NjBcdl ZKr1QN2HloJC3yKkBHQuJdq9d2cM+7xp6tFUn7plO+t1g9h+iAf5c1n1/Il0Hwo4 1m4rpolzAek6AFDS1/Rv948Ljn+y88CR9jVqvUYrO7MLRMYuAnNW0ilpUISOc5qO 8bc7tc133PuQwkswqUMtNx181SPCIyVvXC3bCxSBWMnDfgsTZg34LzTKw/+u8ug= =PC8r -----END PGP SIGNATURE----- --57MpaOtX2hA2kGfr6Sxh18qGv8k6SQEBN--