From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCTwn-0007zz-65 for qemu-devel@nongnu.org; Mon, 13 Jun 2016 11:38:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCTwi-0005nd-68 for qemu-devel@nongnu.org; Mon, 13 Jun 2016 11:38:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCTwh-0005nV-Tq for qemu-devel@nongnu.org; Mon, 13 Jun 2016 11:38:36 -0400 References: <1465409584-16308-1-git-send-email-haris.phnx@gmail.com> <575882EC.1090906@redhat.com> From: Eric Blake Message-ID: <575ED37A.10004@redhat.com> Date: Mon, 13 Jun 2016 09:38:34 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h7QeVM9T72DtmmKJb4h4kdTn3cIxOc20b" Subject: Re: [Qemu-devel] [Qemu-devel [RFC] [WIP] v2] Keeping the Source side alive incase of network failure (Migration recovery from network failure) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: haris iqbal Cc: QEMU Developers , "Dr. David Alan Gilbert" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --h7QeVM9T72DtmmKJb4h4kdTn3cIxOc20b Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2016 12:38 AM, haris iqbal wrote: >>> ## >>> { 'enum': 'RunState', >>> 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'pau= sed', >>> 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-v= m', >>> 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog= ', >>> - 'guest-panicked' ] } >>> + 'guest-panicked', 'postmigrate-recovery' ] } >> >> Adding new enums can cause existing clients like libvirt to do weird >> things if they aren't expecting the new state. Are we sure we want to = do >> it? > I think so. If we do not have a new state, then one would not know > that the VM is in recovery. >=20 >> Is it a state that cannot be entered by default, but only in >> response to a client request that proves the client is new enough to >> expect the new state? >=20 > I did not quite understand what you are trying to say. >=20 A client that is not expecting the new 'postmigrate-recovery' state may mishandle a VM that is in that state. So I'm suggesting that we may want to special case this state, and make it possible to enter the state only if the client has done something first to inform qemu that it understands what it means for a VM to be in that state. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --h7QeVM9T72DtmmKJb4h4kdTn3cIxOc20b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXXtN6AAoJEKeha0olJ0NqgnkH/io4fRNHWgGuzu3t9dz03CWs pWHwTwfKwdgGTfaS7SnoJ2YXpXb7ZH/PR78LLw4xq+ItwP2kVs1K0zlGeyKafw1J oA5v8rBxa2qT/PtpTrM858aEYk2ead37lVL435i03OsQvhBDFP1t5zVb8a3/MOuU ICydYmGEBbCAVkfnKXJTpLZkZxgbsJ4TD63y3WThUnoFOwPlqmHGzT6jAUFb2AhJ /yEPX9CzGYR2yTGULMOdv0FWULHoD3mHO7nEUIvcQAvz9icSdrfCJlfshRAnFAP1 ILYpcAr5EF+flkqZThP9xqBrJv8/u4h7O2MHuH11VnEWs4YEhXml8TiAkx9E4cE= =WHK2 -----END PGP SIGNATURE----- --h7QeVM9T72DtmmKJb4h4kdTn3cIxOc20b--