From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCUIR-0004oe-Kb for qemu-devel@nongnu.org; Mon, 13 Jun 2016 12:01:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCUIL-0002Iw-TP for qemu-devel@nongnu.org; Mon, 13 Jun 2016 12:01:02 -0400 References: <1465805418-15906-1-git-send-email-thuth@redhat.com> <575ED0F2.2080900@redhat.com> From: Thomas Huth Message-ID: <575ED8B1.10207@redhat.com> Date: Mon, 13 Jun 2016 18:00:49 +0200 MIME-Version: 1.0 In-Reply-To: <575ED0F2.2080900@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wNFGB4FqUwwGu6k8bAJDNEcK96OUp08g2" Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Use (unsigned long) typecasts when using "%lu" format string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wNFGB4FqUwwGu6k8bAJDNEcK96OUp08g2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 13.06.2016 17:27, Eric Blake wrote: > On 06/13/2016 02:10 AM, Thomas Huth wrote: >> Some source code analyzers like cppcheck spill out a warning if >> the sign of the argument does not match the format string. >> >> Ticket: https://bugs.launchpad.net/qemu/+bug/1589564 >> Signed-off-by: Thomas Huth >> --- >> hw/scsi/scsi-disk.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c >> index 1881969..36f8a85 100644 >> --- a/hw/scsi/scsi-disk.c >> +++ b/hw/scsi/scsi-disk.c >> @@ -2060,13 +2060,13 @@ static int32_t scsi_disk_emulate_command(SCSIR= equest *req, uint8_t *buf) >> } >> break; >> case MODE_SELECT: >> - DPRINTF("Mode Select(6) (len %lu)\n", (long)r->req.cmd.xfer);= >> + DPRINTF("Mode Select(6) (len %lu)\n", (unsigned long)r->req.c= md.xfer); >=20 > Why do we need a cast in the first place? r->req.cmd.xfer is size_t, s= o > why not just "Mode Select(6) (len %zu)\n", r->req.cmd.xfer)? That sounds good, too. Do you want to provide a patch, or shall I do a v2 of my patch? Thomas --wNFGB4FqUwwGu6k8bAJDNEcK96OUp08g2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXXti1AAoJEC7Z13T+cC21V0YP/09VlFuJf2VV61qf2XWcfqWb jwBWoIuZcN+4LH1aC5oJZbKFa4Ln9zpIWsiSA3gLErS9oX9RamMgqtg8Fn1AoLtp yN3E2Rtdqo8EFz1vDApCBpGN2K8mx8KnlvSsQr1rx6+X+7uXKTuomiG5913ZZN3y zCP6pM7OnvPJ29cZL1edh/J9JBnRWaufMvBJUp6P2Mcczcn41DCtVlOt4sl8rJAq JbXyGmjnxMpDveBDpyCTZ2MCubESPnyWBBybeSz+CSWxSOxEuSJRHZWe2T+3Txlw n9v4t5Uzi2O/YArWur9BlCBDttozF0W+mWG/eeFuIJBfW5ixlUY5Uib5njgplTnf lCIn/yNRtjs7qSPwBX1magknamtJaD++FLygTlqFdO/BFc65hr7nKRzf/ZqBRFJh DrG5kcFTmpyMOG0E6YuKmn84aq+EQI7wpTmavtqpuMtslwmpy7HL7C7mbfy41Obx HT0Fv9qqcKbQoA1STWAm4dFx4YiGFoaXHGm5ZAOvisVASLydv5kjlUqEI4jdsDta Xx3PJw5oyM0AKND1pYzM5iToOcifbcVcAPo3Z2ujHsaEKIH2Mpg/enWA+ddm9oql xQOYP4wQC29mzzfRxakx/vDZr9C1VPYmg8Av+CfWicKmN5+pNKz4jlZ5sVm98CbL lEJRhwQ7ReRLc5g1j/kQ =veWd -----END PGP SIGNATURE----- --wNFGB4FqUwwGu6k8bAJDNEcK96OUp08g2--