From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCULU-0007Gp-Df for qemu-devel@nongnu.org; Mon, 13 Jun 2016 12:04:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCULT-0002tD-9I for qemu-devel@nongnu.org; Mon, 13 Jun 2016 12:04:12 -0400 References: <1465805418-15906-1-git-send-email-thuth@redhat.com> <575ED0F2.2080900@redhat.com> <575ED8B1.10207@redhat.com> From: Eric Blake Message-ID: <575ED979.8090405@redhat.com> Date: Mon, 13 Jun 2016 10:04:09 -0600 MIME-Version: 1.0 In-Reply-To: <575ED8B1.10207@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3NBLkJQsLljK7qrWQHn7xwW22eKRw96s2" Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Use (unsigned long) typecasts when using "%lu" format string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3NBLkJQsLljK7qrWQHn7xwW22eKRw96s2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2016 10:00 AM, Thomas Huth wrote: > On 13.06.2016 17:27, Eric Blake wrote: >> On 06/13/2016 02:10 AM, Thomas Huth wrote: >>> Some source code analyzers like cppcheck spill out a warning if >>> the sign of the argument does not match the format string. >>> >>> Ticket: https://bugs.launchpad.net/qemu/+bug/1589564 >>> Signed-off-by: Thomas Huth >>> --- >>> hw/scsi/scsi-disk.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c >>> index 1881969..36f8a85 100644 >>> --- a/hw/scsi/scsi-disk.c >>> +++ b/hw/scsi/scsi-disk.c >>> @@ -2060,13 +2060,13 @@ static int32_t scsi_disk_emulate_command(SCSI= Request *req, uint8_t *buf) >>> } >>> break; >>> case MODE_SELECT: >>> - DPRINTF("Mode Select(6) (len %lu)\n", (long)r->req.cmd.xfer)= ; >>> + DPRINTF("Mode Select(6) (len %lu)\n", (unsigned long)r->req.= cmd.xfer); >> >> Why do we need a cast in the first place? r->req.cmd.xfer is size_t, = so >> why not just "Mode Select(6) (len %zu)\n", r->req.cmd.xfer)? >=20 > That sounds good, too. Do you want to provide a patch, or shall I do a > v2 of my patch? Up to Paolo, since he's already queued v1. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3NBLkJQsLljK7qrWQHn7xwW22eKRw96s2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXXtl5AAoJEKeha0olJ0NqNLIH/jcrXbI5SVeTVF+0j0uu6xOj 8U5vn1nA7LKPYQ35pphiBbYI7k6D3gpBxJvtacHPcE2nMgdUFBQG5oZSdcpB7K2/ 5GhSvTK2hhme4yCQD10iRiTk7YhT8cxDPEMSV1tT6Su1l/6d61bOxtKpKpbxwyXb RHvPwDYK7XugaoYsXmCQs5Qw6XHJk7deJDJVzwglfPEtt1KE2pU5bxo2FZBo6l7W wPZdCN0t5c1IsctBdSGA+B7O0Zw1ybLttRNmCIymmxAPin+PXfACOKXVQXFB1Yza ov2L5KmXgBTrnHkqHfpksazCZijylbpCja1VIjkIrCuxmlCxO4hMeup/ciCGock= =Uo+/ -----END PGP SIGNATURE----- --3NBLkJQsLljK7qrWQHn7xwW22eKRw96s2--