From: Eric Blake <eblake@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] doc: move text describing --trace to specific .texi file
Date: Mon, 13 Jun 2016 13:37:01 -0600 [thread overview]
Message-ID: <575F0B5D.7060809@redhat.com> (raw)
In-Reply-To: <1465837105-11206-2-git-send-email-den@openvz.org>
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
On 06/13/2016 10:58 AM, Denis V. Lunev wrote:
> This text will be included to qemu-nbd/qemu-img mans in the next patches.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> ---
> +++ b/qemu-option-trace.texi
> @@ -0,0 +1,27 @@
> +@findex -trace
> +
I think the @findex entry should remain per-file, and not in the include
(since the other executables will spell it '--trace', and only qemu
proper accepts the shorthand '-trace').
> +++ b/qemu-options.hx
> @@ -3661,33 +3661,7 @@ STEXI
> HXCOMM This line is not accurate, as some sub-options are backend-specific but
> HXCOMM HX does not support conditional compilation of text.
> @item -trace [events=@var{file}][,file=@var{file}]
> -@findex -trace
Otherwise, it looks fine to me.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-13 19:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 16:58 [Qemu-devel] [PATCH v4 0/6] trace: enable tracing in qemu-io/qemu-nbd/qemu-img Denis V. Lunev
2016-06-13 16:58 ` [Qemu-devel] [PATCH 1/6] doc: move text describing --trace to specific .texi file Denis V. Lunev
2016-06-13 19:37 ` Eric Blake [this message]
2016-06-13 16:58 ` [Qemu-devel] [PATCH 2/6] trace: move qemu_trace_opts to trace/control.c Denis V. Lunev
2016-06-13 16:58 ` [Qemu-devel] [PATCH 3/6] trace: enable tracing in qemu-io Denis V. Lunev
2016-06-13 16:58 ` [Qemu-devel] [PATCH 4/6] trace: enable tracing in qemu-nbd Denis V. Lunev
2016-06-13 19:38 ` Eric Blake
2016-06-13 16:58 ` [Qemu-devel] [PATCH 5/6] qemu-img: move common options parsing before commands processing Denis V. Lunev
2016-06-13 19:44 ` Eric Blake
2016-06-13 16:58 ` [Qemu-devel] [PATCH 6/6] trace: enable tracing in qemu-img Denis V. Lunev
2016-06-13 19:45 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575F0B5D.7060809@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).