From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57283)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bCXfY-0006SP-OA
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 15:37:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bCXfX-000591-Jg
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 15:37:08 -0400
References: <1465837105-11206-1-git-send-email-den@openvz.org>
	<1465837105-11206-2-git-send-email-den@openvz.org>
From: Eric Blake <eblake@redhat.com>
Message-ID: <575F0B5D.7060809@redhat.com>
Date: Mon, 13 Jun 2016 13:37:01 -0600
MIME-Version: 1.0
In-Reply-To: <1465837105-11206-2-git-send-email-den@openvz.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="hQcdEiimW7twcc4t4gEngwiqVxtJwOVMX"
Subject: Re: [Qemu-devel] [PATCH 1/6] doc: move text describing --trace to
 specific .texi file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Kevin Wolf <kwolf@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--hQcdEiimW7twcc4t4gEngwiqVxtJwOVMX
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/13/2016 10:58 AM, Denis V. Lunev wrote:
> This text will be included to qemu-nbd/qemu-img mans in the next patche=
s.
>=20
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> ---

> +++ b/qemu-option-trace.texi
> @@ -0,0 +1,27 @@
> +@findex -trace
> +

I think the @findex entry should remain per-file, and not in the include
(since the other executables will spell it '--trace', and only qemu
proper accepts the shorthand '-trace').

> +++ b/qemu-options.hx
> @@ -3661,33 +3661,7 @@ STEXI
>  HXCOMM This line is not accurate, as some sub-options are backend-spec=
ific but
>  HXCOMM HX does not support conditional compilation of text.
>  @item -trace [events=3D@var{file}][,file=3D@var{file}]
> -@findex -trace

Otherwise, it looks fine to me.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--hQcdEiimW7twcc4t4gEngwiqVxtJwOVMX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJXXwtdAAoJEKeha0olJ0Nq7UEH/iUWlbQv/cvs4X3Bgc3iGHJv
6LIUCNXkiyxnS+joacWb/ywIKcXr2pFpPZj40buqwNH5X6SkR+JtdythgcdbzG+r
mWx+7xU28u8C75LX3oJYmpAcjMGmdcdHDeYYz+BKBNYCJ6QZOFNTHM2eHGJyGO6I
9/NGNH5OOZHynM5C2zR9oP6tMbi2fkT6jw6XUMpVy2AcNZH4E0j73r6KBNmd0XBY
liODDUQbLDmmCqGkyeNQ1Zy5CBwSekKsK97N9gSJzm66oy8lNeOX2huu2JICEoBn
KoUIiXkOmNsNy37lvQW5vFKRuUlqPrML72e9j3eo53PGmqHabNkxFUxRLMcszt4=
=wlGz
-----END PGP SIGNATURE-----

--hQcdEiimW7twcc4t4gEngwiqVxtJwOVMX--