From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57517)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bCXhL-0007hK-Cc
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 15:39:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bCXhJ-0005Ma-Bi
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 15:38:58 -0400
References: <1465837105-11206-1-git-send-email-den@openvz.org>
	<1465837105-11206-5-git-send-email-den@openvz.org>
From: Eric Blake <eblake@redhat.com>
Message-ID: <575F0BCA.2020004@redhat.com>
Date: Mon, 13 Jun 2016 13:38:50 -0600
MIME-Version: 1.0
In-Reply-To: <1465837105-11206-5-git-send-email-den@openvz.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="QgpvRQ8xFIx6r7Mx1irF9d0E3OINEjjVb"
Subject: Re: [Qemu-devel] [PATCH 4/6] trace: enable tracing in qemu-nbd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Kevin Wolf <kwolf@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--QgpvRQ8xFIx6r7Mx1irF9d0E3OINEjjVb
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/13/2016 10:58 AM, Denis V. Lunev wrote:
> Please note, trace_init_backends() must be called in the final process,=

> i.e. after daemonization. This is necessary to keep tracing thread in
> the proper process.
>=20
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> ---
>  Makefile      |  2 +-
>  qemu-nbd.c    | 18 +++++++++++++++++-
>  qemu-nbd.texi |  2 ++
>  3 files changed, 20 insertions(+), 2 deletions(-)
>=20

> +++ b/qemu-nbd.c

> @@ -88,6 +90,8 @@ static void usage(const char *name)
>  "General purpose options:\n"
>  "  --object type,id=3DID,...   define an object such as 'secret' for p=
roviding\n"
>  "                            passwords and/or encryption keys\n"
> +"  -T, --trace [[enable=3D]<pattern>][,events=3D<file>][,file=3D<file>=
]\n"
> +"                            specify tracing options\n"

> +++ b/qemu-nbd.texi
> @@ -92,6 +92,8 @@ Display extra debugging information
>  Display this help and exit
>  @item -V, --version
>  Display version information and exit
> +@item -T, --trace [events=3D@var{file}][,file=3D@var{file}]

Still not consistent.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--QgpvRQ8xFIx6r7Mx1irF9d0E3OINEjjVb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJXXwvKAAoJEKeha0olJ0NqfpUH/00uTxH4DTC2RGFlNeO7qWBH
/b9xVphyCJtQXvZA+Rg3fvfXcjer0LClEwyMxijkOedwjlm+mFGXbcQlDIhxo0FS
Uyj6tqxqgJhimBQxMqvTbm79nLGqWxP1lVNrgILGxhUOCrCdCMXYhvBH2opxIces
eb69I1u/PgPgBqsGHp/iPVRRWMPCidrRbEBZHqZs4qNgUEC6wWEJ4txeZU6Bg7P+
GCuxwycvsRD2LN6iyV1lDXUrQzlwcM6m6YMrA1T80HmfZEWz6ztkRahL8vxAncKH
dBCukcJYWu1ztyJwv9YfTjaWXoHy97MvI9FqKnNzT3acsPC6gBhsZJYn0WTZmrc=
=/OoC
-----END PGP SIGNATURE-----

--QgpvRQ8xFIx6r7Mx1irF9d0E3OINEjjVb--