Re: [Qemu-devel] [PATCH 6/6] trace: enable tracing in qemu-img

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]

On 06/13/2016 10:58 AM, Denis V. Lunev wrote:
> The command will work this way:
>     qemu-img --trace qcow2* create -f qcow2 1.img 64G
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Suggested by: Daniel P. Berrange <berrange@redhat.com>
> CC: Eric Blake <eblake@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> ---
>  Makefile      |  2 +-
>  qemu-img.c    | 18 +++++++++++++++++-
>  qemu-img.texi |  2 ++
>  3 files changed, 20 insertions(+), 2 deletions(-)
> 

> +++ b/qemu-img.c

> @@ -92,6 +94,8 @@ static void QEMU_NORETURN help(void)
>             "\n"
>             "    '-h', '--help'       display this help and exit\n"
>             "    '-V', '--version'    output version information and exit\n"
> +           "    '-T', '--trace'      [[enable=]<pattern>][,events=<file>][,file=<file>]\n"
> +           "                         specify tracing options\n"
>             "\n"

> +++ b/qemu-img.texi
> @@ -22,6 +22,8 @@ Standard options:
>  Display this help and exit
>  @item -V, --version
>  Display version information and exit
> +@item -T, --trace [events=@var{file}][,file=@var{file}]

Still inconsistent.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]