From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bCXo5-0004qa-3E
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 15:45:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bCXo3-0006pP-Ve
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 15:45:57 -0400
References: <1465837105-11206-1-git-send-email-den@openvz.org>
	<1465837105-11206-7-git-send-email-den@openvz.org>
From: Eric Blake <eblake@redhat.com>
Message-ID: <575F0D6C.2070103@redhat.com>
Date: Mon, 13 Jun 2016 13:45:48 -0600
MIME-Version: 1.0
In-Reply-To: <1465837105-11206-7-git-send-email-den@openvz.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="xiJLl1ANRA1M7LnXIMwnoWtgQDAqsfkpI"
Subject: Re: [Qemu-devel] [PATCH 6/6] trace: enable tracing in qemu-img
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Kevin Wolf <kwolf@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--xiJLl1ANRA1M7LnXIMwnoWtgQDAqsfkpI
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/13/2016 10:58 AM, Denis V. Lunev wrote:
> The command will work this way:
>     qemu-img --trace qcow2* create -f qcow2 1.img 64G
>=20
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Suggested by: Daniel P. Berrange <berrange@redhat.com>
> CC: Eric Blake <eblake@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> ---
>  Makefile      |  2 +-
>  qemu-img.c    | 18 +++++++++++++++++-
>  qemu-img.texi |  2 ++
>  3 files changed, 20 insertions(+), 2 deletions(-)
>=20

> +++ b/qemu-img.c

> @@ -92,6 +94,8 @@ static void QEMU_NORETURN help(void)
>             "\n"
>             "    '-h', '--help'       display this help and exit\n"
>             "    '-V', '--version'    output version information and ex=
it\n"
> +           "    '-T', '--trace'      [[enable=3D]<pattern>][,events=3D=
<file>][,file=3D<file>]\n"
> +           "                         specify tracing options\n"
>             "\n"

> +++ b/qemu-img.texi
> @@ -22,6 +22,8 @@ Standard options:
>  Display this help and exit
>  @item -V, --version
>  Display version information and exit
> +@item -T, --trace [events=3D@var{file}][,file=3D@var{file}]

Still inconsistent.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--xiJLl1ANRA1M7LnXIMwnoWtgQDAqsfkpI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJXXw1sAAoJEKeha0olJ0NqNKYH/3Q36CPwRgAa7VfKl4Jx5Jnk
yYhW//k17P6c4rWV8J4KOib+jzg1IManHQJPCa9OOwKMwxgE+kEBXdv9DiRd30XT
UDonULuNPH27cNvIMvXPBiMXc1oJX5FQDmhdE/4oRYplD2xopa52VPp7YvmeDWlX
KzO5NyJlD8VmKTL90v3/6y8SBBlubDMUi7Gxx6x+fgvuFtguf8bLKv/sAAunVdw0
d+GAj2KtY+4wRZ47Ouyf19jANNj/O4CQULgL1bFdQ0urOGAT6ocN0xYt47Ga5Wj5
tx43eW5KVeN+XICO7svudUNhjJqa9clzSA/3AE3gGjkzYSA/13sL7r+fvXDlOuM=
=+qkd
-----END PGP SIGNATURE-----

--xiJLl1ANRA1M7LnXIMwnoWtgQDAqsfkpI--