From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCiD7-0005BT-BA for qemu-devel@nongnu.org; Tue, 14 Jun 2016 02:52:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCiCy-0007pn-HF for qemu-devel@nongnu.org; Tue, 14 Jun 2016 02:52:28 -0400 Received: from 5.mo177.mail-out.ovh.net ([46.105.39.154]:36947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCiCy-0007pY-As for qemu-devel@nongnu.org; Tue, 14 Jun 2016 02:52:20 -0400 Received: from player746.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo177.mail-out.ovh.net (Postfix) with ESMTP id 51689FF95DF for ; Tue, 14 Jun 2016 08:52:18 +0200 (CEST) References: <1465795496-15071-1-git-send-email-clg@kaod.org> <1465795496-15071-3-git-send-email-clg@kaod.org> <20160614061527.GO4882@voom.fritz.box> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <575FA99C.9000507@kaod.org> Date: Tue, 14 Jun 2016 08:52:12 +0200 MIME-Version: 1.0 In-Reply-To: <20160614061527.GO4882@voom.fritz.box> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 02/10] ppc: Create cpu_ppc_set_papr() helper (for LPCR) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Benjamin Herrenschmidt On 06/14/2016 08:15 AM, David Gibson wrote: > On Mon, Jun 13, 2016 at 07:24:48AM +0200, C=E9dric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> And move the code adjusting the MSR mask and calling kvmppc_set_papr() >> to it. This allows us to add a few more things such as disabling setti= ng >> of MSR:HV and appropriate LPCR bits which will be used when fixing >> the exception model. >> >> Signed-off-by: Benjamin Herrenschmidt >> Reviewed-by: David Gibson >> [clg: previous commit 26a7f1291bb5 did not include the LPCR setting as >> it was not needed at the time ] >=20 > I see how this came about, but it means the commit message (both long > and short) is confusingly mismatched from the code now. OK. I will work on it. For my education, how much can we change the initial changelog of a patch= ? Is it considered as part of the code ?=20 Thanks, C.=20