From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47331)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bCkDi-0005N8-Rf
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 05:01:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bCkDd-00022w-0K
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 05:01:14 -0400
Received: from mail-db3on0121.outbound.protection.outlook.com
	([157.55.234.121]:44094
	helo=emea01-db3-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bCkDc-00022J-8P
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 05:01:08 -0400
References: <1465378757-15271-1-git-send-email-den@openvz.org>
	<20160608112357.GD5324@noname.str.redhat.com>
	<575FC184.4090903@openvz.org>
	<20160614084458.GD4916@noname.str.redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <575FC7CA.1060106@openvz.org>
Date: Tue, 14 Jun 2016 12:00:58 +0300
MIME-Version: 1.0
In-Reply-To: <20160614084458.GD4916@noname.str.redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, Paolo Bonzini <pbonzini@redhat.com>

On 06/14/2016 11:44 AM, Kevin Wolf wrote:
> Am 14.06.2016 um 10:34 hat Denis V. Lunev geschrieben:
>> On 06/08/2016 02:23 PM, Kevin Wolf wrote:
>>> Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben:
>>>> From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>>
>>>> Acquire aio context before run command, this is mandatory for unit tests.
>>>>
>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>>>> CC: Kevin Wolf <kwolf@redhat.com>
>>>> CC: Paolo Bonzini <pbonzini@redhat.com>
>>> Looks right to me, but why "mandatory for unit tests"? Does this fix an
>>> observable bug in unit tests? If so, we should be more specific in the
>>> commit message.
>>>
>>> But in fact, I would only expect it to make a difference for dataplane
>>> and I don't think we have test cases that use both the 'qemu-io' HMP
>>> command and dataplane.
>>>
>>> Kevin
>> the problem is that it is usually difficult to understand that
>> the problem is in locking and find where the locking is missed.
>> Here we do have a place, which is used by unit testing, with
>> a locking missed.
>>
>> May be now tests are not failing, but IMHO these tests MUST
>> be fixed to accommodate future changes and thus this patch
>> is mandatory for them.
> I was never objecting to the patch, but just curious about the details
> of a possible failure you were seeing because I didn't see how to hit
> it in practice without dataplane.
>
> Sorry for forgetting about the patch, I've applied it now.
>
> Kevin
thank you ;)

Den