From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCtfK-0002AQ-6J for qemu-devel@nongnu.org; Tue, 14 Jun 2016 15:06:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCtfF-0006RM-Te for qemu-devel@nongnu.org; Tue, 14 Jun 2016 15:06:21 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCtfF-0006R6-Lr for qemu-devel@nongnu.org; Tue, 14 Jun 2016 15:06:17 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5EJ40wL012990 for ; Tue, 14 Jun 2016 15:06:16 -0400 Received: from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154]) by mx0a-001b2d01.pphosted.com with ESMTP id 23jch4gq82-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 14 Jun 2016 15:06:16 -0400 Received: from localhost by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Jun 2016 13:06:15 -0600 Reply-To: jjherne@linux.vnet.ibm.com References: <1465928228-1184-1-git-send-email-stefanha@redhat.com> From: "Jason J. Herne" Date: Tue, 14 Jun 2016 15:06:11 -0400 MIME-Version: 1.0 In-Reply-To: <1465928228-1184-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Message-Id: <576055A3.5000600@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 0/5] blockjob: AioContext change support for mirror and backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Paolo Bonzini , Jeff Cody , mreitz@redhat.com On 06/14/2016 02:17 PM, Stefan Hajnoczi wrote: > v4: > * Add .pause()/.resume() callbacks to really quiesce during > block_job_pause_point() [Paolo] > * Add AioContext change support for backup block job > * Tested drive_mirror + migration and drive_backup + reboot > > v3: > * Push infrastructure down into blockjob.c so other jobs can reuse it [Stefan] > * Tested with drive_mirror + migration [Stefan] > > v2: > * Fam introduced the concept of a synchronous aio_poll() loop to quiesce the > block job during detach > > When dataplane is enabled or disabled the drive switches to a new AioContext. > The mirror and backup block jobs must also move to the new AioContext so that > drive accesses are always made within its AioContext. > > This series extends the block job pause functionality so that detaching from an > AioContext pauses the job and attaching to the new AioContext resumes the job. > > Pause points are added to the mirror job so that long I/O loops can yield for > an AioContext switch. Other block jobs need pause points too but this can be > done as a follow-up series. I just tested v4 on s390. It appears to fix our original problem without any hiccups. Thank you Stefan! :) Let me know if you need any more testing. -- -- Jason J. Herne (jjherne@linux.vnet.ibm.com)