qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include
Date: Tue, 14 Jun 2016 16:05:12 -0600	[thread overview]
Message-ID: <57607F98.50807@redhat.com> (raw)
In-Reply-To: <1464747811-26917-1-git-send-email-famz@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

On 05/31/2016 08:23 PM, Fam Zheng wrote:
> The file is only included from the top Makefile. Rename it to reflect
> this more obviously.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  Makefile                             | 2 +-
>  tests/{Makefile => Makefile.include} | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename tests/{Makefile => Makefile.include} (100%)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/Makefile b/Makefile
> index 3a3c5dc..0cd111b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -161,7 +161,7 @@ dummy := $(call unnest-vars,, \
>                  common-obj-m)
>  
>  ifneq ($(wildcard config-host.mak),)
> -include $(SRC_PATH)/tests/Makefile
> +include $(SRC_PATH)/tests/Makefile.include
>  endif
>  
>  all: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all modules
> diff --git a/tests/Makefile b/tests/Makefile.include
> similarity index 100%
> rename from tests/Makefile
> rename to tests/Makefile.include
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2016-06-14 22:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01  2:23 [Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include Fam Zheng
2016-06-14 22:05 ` Eric Blake [this message]
2016-06-15  0:33   ` Fam Zheng
2016-06-15  1:41     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57607F98.50807@redhat.com \
    --to=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).