From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40099)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bCwYn-0004cX-3Q
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 18:11:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bCwYi-0007o6-Rd
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 18:11:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46352)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bCwYi-0007o2-Ll
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 18:11:44 -0400
References: <20160614180734.8782-1-sbruno@freebsd.org>
From: Eric Blake <eblake@redhat.com>
Message-ID: <5760811E.8040907@redhat.com>
Date: Tue, 14 Jun 2016 16:11:42 -0600
MIME-Version: 1.0
In-Reply-To: <20160614180734.8782-1-sbruno@freebsd.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="ELlV9V86VGteDks4SJNJLlluGR7FRDI7T"
Subject: Re: [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to
 resolve non-fatal build error on FreeBSD.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sean Bruno <sbruno@freebsd.org>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--ELlV9V86VGteDks4SJNJLlluGR7FRDI7T
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/14/2016 12:07 PM, Sean Bruno wrote:
> The --quiet argument is not available on all operating systems.  Use -s=

> instead to match the rest of the Makefile uses.  This fixes a non-fatal=

> error seen on FreeBSD.
>=20
> Signed-off-by: Sean Bruno <sbruno@freebsd.org>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

See also my pending patch related to this code:
https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg02375.html

if Paolo wants to pull in all the changes related to version generation
in his next pull request.

>=20
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
>  				printf '""\n'; \
>  			fi; \
>  		fi) > $@.tmp)
> -	$(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> +	$(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
> =20
>  config-host.h: config-host.h-timestamp
>  config-host.h-timestamp: config-host.mak
>=20

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--ELlV9V86VGteDks4SJNJLlluGR7FRDI7T
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEbBAEBCAAGBQJXYIEeAAoJEKeha0olJ0Nqj98H90GEPga7pKKlfW1ROhbPnvpP
cEpvWLQhGGvQVIj21OZNS0Rll2YOUKI4P24KIIxAJx+R10cSqMytWhpCgwaluD40
Vq1X36J3xS61Pko8icbLH4rIsMoMeEWROb0VuzKzqpo/W5KvFRVvlkTNZJqViqbg
vP1GkuYIg+NgIAxQMsjQtZBbhxz7eElAULVHdhTDBjshwIVTUR3d/GvYH+LOghKh
jN0um1qjZttcNPbAoaU6TuqU/DJr0Zm/9Ugk2394rpnQ2kOYpnXGzBxYsLBg/cEK
3fZUOKxhnrE6fxzMWX/G3sQakUscfvVBaohobS8jw4Bl6XMI6jtOC++i4uUo4Q==
=SH5q
-----END PGP SIGNATURE-----

--ELlV9V86VGteDks4SJNJLlluGR7FRDI7T--