From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCx31-000312-Ax for qemu-devel@nongnu.org; Tue, 14 Jun 2016 18:43:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCx2z-00072U-CS for qemu-devel@nongnu.org; Tue, 14 Jun 2016 18:43:02 -0400 References: <1459967330-4573-1-git-send-email-mreitz@redhat.com> <20160503152336.GJ3917@noname.str.redhat.com> From: Eric Blake Message-ID: <5760886D.9020105@redhat.com> Date: Tue, 14 Jun 2016 16:42:53 -0600 MIME-Version: 1.0 In-Reply-To: <20160503152336.GJ3917@noname.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xaKltmVU5w1TxmFEB5uE1XgoWqBjKe0xn" Subject: Re: [Qemu-devel] [PATCH v3 for-2.7 00/14] qapi: Allow blockdev-add for NBD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Max Reitz Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Paolo Bonzini , "Daniel P . Berrange" , Markus Armbruster , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xaKltmVU5w1TxmFEB5uE1XgoWqBjKe0xn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/03/2016 09:23 AM, Kevin Wolf wrote: > Am 06.04.2016 um 20:28 hat Max Reitz geschrieben: >> Turns out NBD is not so simple to do if you do it right. Anyway, this >> series adds blockdev-add support for NBD clients. >=20 > What the series does seems to make sense to me, though things would be = a > bit nicer (especially on the command line) if SocketAddress had been a > flat union from the beginning. It's too late to change now, and I gues= s > the ugliness isn't worth duplicating it. I'm sorely tempted to make SocketAddress a flat union anyways (or even an alternate that can be flat or nested at will), if only for convenience. But that's a pipe dream - there's probably not enough time before 2.7 to actually achieve it. >=20 > I'll leave the in-detail review to our NBD folks. >=20 > Kevin >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xaKltmVU5w1TxmFEB5uE1XgoWqBjKe0xn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXYIhtAAoJEKeha0olJ0NqowQIAKFz4xYAItgN13kwtOg+b8xO Ox5jIfbrUwmtzH7iDZc6krhQl5oepQ4npJEv0cIGAuua7xqZXdpMKxTqy134NFrv S33Au3WNKathL+aj0WhJEc7id/5JpHV9/HjhUKpxxJNlxBQMY3Wppr3jyd/JoGRt k65TstDvRmd+PqbNXP9DpnNvcU9BZtFORgGYDRc8ClKQq6oOuShWrLF/DoR0b/7h HvXkqoniYcnHVjixkQ/81eAQNVmRBlR4tq/R+iozngFSSVSq1OrEmdrQkCLqJKFO mIET4Q3cQkYp0uOhBl/DbnObfJ60hdVpsRTy4mcs4WwAprZSQYqMyGeEf3JRYW8= =ocg6 -----END PGP SIGNATURE----- --xaKltmVU5w1TxmFEB5uE1XgoWqBjKe0xn--