From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39706)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bD1Ny-0008Kx-EU
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 23:20:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bD1Nw-0007Z9-8p
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 23:20:57 -0400
References: <1465917916-22348-1-git-send-email-den@openvz.org>
	<1465917916-22348-6-git-send-email-den@openvz.org>
From: Eric Blake <eblake@redhat.com>
Message-ID: <5760C98F.4010600@redhat.com>
Date: Tue, 14 Jun 2016 21:20:47 -0600
MIME-Version: 1.0
In-Reply-To: <1465917916-22348-6-git-send-email-den@openvz.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="HguE8HFB3jj9VcO4jnKGcJEfFJTlQV0dP"
Subject: Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of
 mirroring of empty disk
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <famz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Jeff Cody <jcody@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--HguE8HFB3jj9VcO4jnKGcJEfFJTlQV0dP
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/14/2016 09:25 AM, Denis V. Lunev wrote:
> We should not take into account zero blocks for delay calculations.
> They are not read and thus IO throttling is not required. In the
> other case VM migration with 16 Tb QCOW2 disk with 4 Gb of data takes
> days.
>=20
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Fam Zheng <famz@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Max Reitz <mreitz@redhat.com>
> CC: Jeff Cody <jcody@redhat.com>
> CC: Eric Blake <eblake@redhat.com>
> ---
>  block/mirror.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Seems reasonable, but I'll let others more familiar with throttling give
the final say.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--HguE8HFB3jj9VcO4jnKGcJEfFJTlQV0dP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJXYMmPAAoJEKeha0olJ0Nq4NkH/i76NtCsDTN/UVNo17nesfVh
YNSfx1ausOnGTfG1NcaawmfrKLIhM/zdEzTfUCyh5Z3N4cFlXCfPODOk3OFoqolF
RP+rDsXiKFdMMgx634QAMt3x0gGGG0lVzzYbwfw2V9yoFcRkyia+ZlSYJ+JJZHBT
P4bd3SE5Bew69EZL+bvLJf3e0mK2/gseeC8bSKzSSRRTlFacnOInD810CflubiyV
VZfMsXBYMwLozBujwmaztqgJq+KfTrziveXVJ0GF0V9P6bJqn7VfWmNgq4Wo3vlx
M2Oi/BU4cZ/hL2kIcLXfY+QorVa5/rWR8h3X8A9nrrdn/HdNG7rOkVKO9+J1Z1A=
=Eu0W
-----END PGP SIGNATURE-----

--HguE8HFB3jj9VcO4jnKGcJEfFJTlQV0dP--