From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bD743-0001pO-Ci for qemu-devel@nongnu.org; Wed, 15 Jun 2016 05:24:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bD741-0005ET-A8 for qemu-devel@nongnu.org; Wed, 15 Jun 2016 05:24:46 -0400 References: <1465917916-22348-1-git-send-email-den@openvz.org> <1465917916-22348-7-git-send-email-den@openvz.org> <20160615092125.GB26488@stefanha-x1.localdomain> From: "Denis V. Lunev" Message-ID: <57611ECD.1000802@openvz.org> Date: Wed, 15 Jun 2016 12:24:29 +0300 MIME-Version: 1.0 In-Reply-To: <20160615092125.GB26488@stefanha-x1.localdomain> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/9] block: pass qiov into before_write notifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, vsementsov@virtuozzo.com, Fam Zheng , Kevin Wolf , Max Reitz , Jeff Cody , Eric Blake On 06/15/2016 12:21 PM, Stefan Hajnoczi wrote: > On Tue, Jun 14, 2016 at 06:25:13PM +0300, Denis V. Lunev wrote: >> Signed-off-by: Denis V. Lunev >> Reviewed-by: Vladimir Sementsov-Ogievskiy >> CC: Stefan Hajnoczi >> CC: Fam Zheng >> CC: Kevin Wolf >> CC: Max Reitz >> CC: Jeff Cody >> CC: Eric Blake >> --- >> block/io.c | 12 +++++++----- >> include/block/block_int.h | 1 + >> 2 files changed, 8 insertions(+), 5 deletions(-) > This patch is missing a commit description. Why is this necessary? > > If you add .qiov then can we remove the .bytes field? this would not be convenient unfortunately. here I have pointer to qiov and this pointer is not always available. Actually it is available only to the write operation. The purpose is to make data being written available for the notifier. Den