From: Richard Henderson <richard.henderson@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 01/16] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h
Date: Mon, 10 Mar 2025 08:17:20 -0700 [thread overview]
Message-ID: <57612d65-aec0-4785-86c3-0c8d647af38a@linaro.org> (raw)
In-Reply-To: <20250310045842.2650784-2-pierrick.bouvier@linaro.org>
On 3/9/25 21:58, Pierrick Bouvier wrote:
> They are now accessible through exec/memory.h instead, and we make sure
> all variants are available for common or target dependent code.
...
> diff --git a/include/exec/memory_ldst.h.inc b/include/exec/memory_ldst.h.inc
> index 92ad74e9560..74519a88de0 100644
> --- a/include/exec/memory_ldst.h.inc
> +++ b/include/exec/memory_ldst.h.inc
> @@ -19,7 +19,8 @@
> * License along with this library; if not, see <http://www.gnu.org/licenses/>.
> */
>
> -#ifdef TARGET_ENDIANNESS
> +uint8_t glue(address_space_ldub, SUFFIX)(ARG1_DECL,
> + hwaddr addr, MemTxAttrs attrs, MemTxResult *result);
> uint16_t glue(address_space_lduw, SUFFIX)(ARG1_DECL,
> hwaddr addr, MemTxAttrs attrs, MemTxResult *result);
You shouldn't be exposing
address_space_lduw
to common code, only
address_space_lduw_be
address_space_lduw_le
etc. I'm not sure what you're trying to do here.
r~
next prev parent reply other threads:[~2025-03-10 15:19 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 4:58 [PATCH 00/16] make system memory API available for common code Pierrick Bouvier
2025-03-10 4:58 ` [PATCH 01/16] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h Pierrick Bouvier
2025-03-10 15:17 ` Richard Henderson [this message]
2025-03-10 16:03 ` Pierrick Bouvier
2025-03-11 0:04 ` Pierrick Bouvier
2025-03-11 14:40 ` Richard Henderson
2025-03-10 4:58 ` [PATCH 02/16] exec/memory_ldst_phys: extract memory_ldst_phys " Pierrick Bouvier
2025-03-11 0:08 ` Pierrick Bouvier
2025-03-10 4:58 ` [PATCH 03/16] include: move target_words_bigendian() from tswap to bswap Pierrick Bouvier
2025-03-10 15:21 ` Richard Henderson
2025-03-10 16:05 ` Pierrick Bouvier
2025-03-10 4:58 ` [PATCH 04/16] exec/memory.h: make devend_memop target agnostic Pierrick Bouvier
2025-03-10 15:25 ` Richard Henderson
2025-03-10 16:04 ` Pierrick Bouvier
2025-03-10 16:30 ` Richard Henderson
2025-03-10 16:38 ` Pierrick Bouvier
2025-03-10 4:58 ` [PATCH 05/16] qemu/bswap: implement {ld,st}.*_p as functions Pierrick Bouvier
2025-03-10 16:08 ` Richard Henderson
2025-03-10 16:14 ` Pierrick Bouvier
2025-03-10 16:37 ` Richard Henderson
2025-03-10 16:43 ` Pierrick Bouvier
2025-03-10 16:53 ` Richard Henderson
2025-03-10 17:09 ` Pierrick Bouvier
2025-03-10 20:17 ` BALATON Zoltan
2025-03-10 20:31 ` Pierrick Bouvier
2025-03-10 4:58 ` [PATCH 06/16] exec/cpu-all.h: we can now remove ld/st macros Pierrick Bouvier
2025-03-10 16:39 ` Richard Henderson
2025-03-10 16:45 ` Pierrick Bouvier
2025-03-10 4:58 ` [PATCH 07/16] codebase: prepare to remove cpu.h from exec/exec-all.h Pierrick Bouvier
2025-03-10 17:22 ` Richard Henderson
2025-03-10 4:58 ` [PATCH 08/16] exec/exec-all: remove dependency on cpu.h Pierrick Bouvier
2025-03-10 17:29 ` Richard Henderson
2025-03-10 4:58 ` [PATCH 09/16] exec/memory-internal: " Pierrick Bouvier
2025-03-10 17:29 ` Richard Henderson
2025-03-10 4:58 ` [PATCH 10/16] exec/ram_addr: " Pierrick Bouvier
2025-03-10 17:29 ` Richard Henderson
2025-03-10 4:58 ` [PATCH 11/16] system/kvm: make kvm_flush_coalesced_mmio_buffer() accessible for common code Pierrick Bouvier
2025-03-10 17:30 ` Richard Henderson
2025-03-10 4:58 ` [PATCH 12/16] exec/ram_addr: call xen_hvm_modified_memory only if xen is enabled Pierrick Bouvier
2025-03-10 17:30 ` Richard Henderson
2025-03-10 4:58 ` [PATCH 13/16] hw/xen: add stubs for various functions Pierrick Bouvier
2025-03-10 17:32 ` Richard Henderson
2025-03-10 4:58 ` [PATCH 14/16] system/physmem: compilation unit is now common to all targets Pierrick Bouvier
2025-03-10 17:32 ` Richard Henderson
2025-03-10 4:58 ` [PATCH 15/16] system/memory: make compilation unit common Pierrick Bouvier
2025-03-10 17:43 ` Richard Henderson
2025-03-10 17:47 ` Pierrick Bouvier
2025-03-10 17:58 ` Richard Henderson
2025-03-10 18:04 ` Pierrick Bouvier
2025-03-10 18:10 ` Richard Henderson
2025-03-10 18:25 ` Pierrick Bouvier
2025-03-10 18:27 ` Philippe Mathieu-Daudé
2025-03-10 18:38 ` Pierrick Bouvier
2025-03-10 4:58 ` [PATCH 16/16] system/ioport: " Pierrick Bouvier
2025-03-10 17:43 ` Richard Henderson
2025-03-10 13:23 ` [PATCH 00/16] make system memory API available for common code BALATON Zoltan
2025-03-10 16:28 ` Pierrick Bouvier
2025-03-10 16:56 ` Pierrick Bouvier
2025-03-10 19:40 ` BALATON Zoltan
2025-03-10 20:26 ` Pierrick Bouvier
2025-03-10 21:02 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57612d65-aec0-4785-86c3-0c8d647af38a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).