From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDAam-0002Zi-Ia for qemu-devel@nongnu.org; Wed, 15 Jun 2016 09:10:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDAai-0007sj-8e for qemu-devel@nongnu.org; Wed, 15 Jun 2016 09:10:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDAah-0007sK-Vq for qemu-devel@nongnu.org; Wed, 15 Jun 2016 09:10:44 -0400 References: <1465409584-16308-1-git-send-email-haris.phnx@gmail.com> <575882EC.1090906@redhat.com> <575ED37A.10004@redhat.com> <20160615130347.GF2272@work-vm> From: Eric Blake Message-ID: <576153D2.2070508@redhat.com> Date: Wed, 15 Jun 2016 07:10:42 -0600 MIME-Version: 1.0 In-Reply-To: <20160615130347.GF2272@work-vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kRse2kNSlCCA2Sk5XIembAFM5NrKSbxlL" Subject: Re: [Qemu-devel] [Qemu-devel [RFC] [WIP] v2] Keeping the Source side alive incase of network failure (Migration recovery from network failure) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: haris iqbal , QEMU Developers This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kRse2kNSlCCA2Sk5XIembAFM5NrKSbxlL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/15/2016 07:03 AM, Dr. David Alan Gilbert wrote: > * Eric Blake (eblake@redhat.com) wrote: >> On 06/13/2016 12:38 AM, haris iqbal wrote: >> >>>>> ## >>>>> { 'enum': 'RunState', >>>>> 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'p= aused', >>>>> 'postmigrate', 'prelaunch', 'finish-migrate', 'restore= -vm', >>>>> 'running', 'save-vm', 'shutdown', 'suspended', 'watchd= og', >>>>> - 'guest-panicked' ] } >>>>> + 'guest-panicked', 'postmigrate-recovery' ] } >>>> >>>> Adding new enums can cause existing clients like libvirt to do weird= >>>> things if they aren't expecting the new state. Are we sure we want t= o do >>>> it? >>> I think so. If we do not have a new state, then one would not know >>> that the VM is in recovery. >>> >>>> Is it a state that cannot be entered by default, but only in >>>> response to a client request that proves the client is new enough to= >>>> expect the new state? >>> >>> I did not quite understand what you are trying to say. >>> >> >> A client that is not expecting the new 'postmigrate-recovery' state ma= y >> mishandle a VM that is in that state. So I'm suggesting that we may >> want to special case this state, and make it possible to enter the sta= te >> only if the client has done something first to inform qemu that it >> understands what it means for a VM to be in that state. >=20 > Do you mean another migration capability? >=20 Sure, that would be an introspectible way - if left off, the state cannot be reached, but if the client turns the capability on, then the state is useful. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kRse2kNSlCCA2Sk5XIembAFM5NrKSbxlL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXYVPSAAoJEKeha0olJ0NqSGYH/3one613X5XhF1ldcGTqZqGp Ry7B7Z+FrL7+hLEfGEyjhIBjNQ1IWvnGoo8bGPBKz7lPcZQBXuGqrSnvOlFBix1/ jx0FMwq7wSawXunK9KcnFC0g98xskwC1mcGWtqTbu2sRUDRIJR+PjA2F6wVd8+UV nQxQhZNpS/I17ir3FkBwi3Awg8ha+Gim1v0yAOSKJuFcO3ZK7dsnVZZVJnDSRYIV JZmJRrtANH3BC5PUuQDVzAe+wwrCXXJQc/ESkYuJLl0Mr5oCWAEfGEgYC9uiJvvD yvFukFzae0eppvOI/1vmLyeVF0wueIimYRugWivQ6f+Csk4h49QwgV8IykAdUNk= =UxD+ -----END PGP SIGNATURE----- --kRse2kNSlCCA2Sk5XIembAFM5NrKSbxlL--