From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36117)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bDCPY-0002H9-5V
	for qemu-devel@nongnu.org; Wed, 15 Jun 2016 11:07:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bDCPT-0008O0-Up
	for qemu-devel@nongnu.org; Wed, 15 Jun 2016 11:07:19 -0400
Received: from mail-db3on0113.outbound.protection.outlook.com
	([157.55.234.113]:23643
	helo=emea01-db3-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1bDCPT-0008Nq-3n
	for qemu-devel@nongnu.org; Wed, 15 Jun 2016 11:07:15 -0400
References: <1465206690-4721-1-git-send-email-den@openvz.org>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <57616F19.5080309@openvz.org>
Date: Wed, 15 Jun 2016 18:07:05 +0300
MIME-Version: 1.0
In-Reply-To: <1465206690-4721-1-git-send-email-den@openvz.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] vnc: remove unused depth argument in
 set_pixel_format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

On 06/06/2016 12:51 PM, Denis V. Lunev wrote:
> Spotted by coverity, reported by Paolo.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   ui/vnc.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index c862fdc..cc94024 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2116,7 +2116,7 @@ static void send_color_map(VncState *vs)
>   }
>   
>   static void set_pixel_format(VncState *vs,
> -                             int bits_per_pixel, int depth,
> +                             int bits_per_pixel,
>                                int big_endian_flag, int true_color_flag,
>                                int red_max, int green_max, int blue_max,
>                                int red_shift, int green_shift, int blue_shift)
> @@ -2124,7 +2124,6 @@ static void set_pixel_format(VncState *vs,
>       if (!true_color_flag) {
>           /* Expose a reasonable default 256 color map */
>           bits_per_pixel = 8;
> -        depth = 8;
>           red_max = 7;
>           green_max = 7;
>           blue_max = 3;
> @@ -2231,7 +2230,7 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len)
>           if (len == 1)
>               return 20;
>   
> -        set_pixel_format(vs, read_u8(data, 4), read_u8(data, 5),
> +        set_pixel_format(vs, read_u8(data, 4),
>                            read_u8(data, 6), read_u8(data, 7),
>                            read_u16(data, 8), read_u16(data, 10),
>                            read_u16(data, 12), read_u8(data, 14),
ping