From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDCyH-0002Sj-Bk for qemu-devel@nongnu.org; Wed, 15 Jun 2016 11:43:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDCyF-00034U-Bn for qemu-devel@nongnu.org; Wed, 15 Jun 2016 11:43:12 -0400 References: <20160615153630.2116-1-mreitz@redhat.com> <20160615153630.2116-3-mreitz@redhat.com> From: Eric Blake Message-ID: <57617788.9010204@redhat.com> Date: Wed, 15 Jun 2016 09:43:04 -0600 MIME-Version: 1.0 In-Reply-To: <20160615153630.2116-3-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h6MnvR3fbpiG26Aa3dgUdSbase3rF7SLe" Subject: Re: [Qemu-devel] [PATCH 2/2] qcow2: Avoid making the L1 table too big List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , qemu-stable@nongnu.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --h6MnvR3fbpiG26Aa3dgUdSbase3rF7SLe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/15/2016 09:36 AM, Max Reitz wrote: > We refuse to open images whose L1 table we deem "too big". Consequently= , > we should not produce such images ourselves. >=20 > Cc: qemu-stable@nongnu.org > Signed-off-by: Max Reitz > --- > block/qcow2-cluster.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c > index 893ddf6..335b9b0 100644 > --- a/block/qcow2-cluster.c > +++ b/block/qcow2-cluster.c > @@ -65,7 +65,7 @@ int qcow2_grow_l1_table(BlockDriverState *bs, uint64_= t min_size, > } > } > =20 > - if (new_l1_size > INT_MAX / sizeof(uint64_t)) { > + if (new_l1_size > QCOW_MAX_L1_SIZE / sizeof(uint64_t)) { > return -EFBIG; > } > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --h6MnvR3fbpiG26Aa3dgUdSbase3rF7SLe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXYXeIAAoJEKeha0olJ0NqhzQH/0pWfyBIAfQS2yXlWEBM8CaS /ELO5jA2aD/zxDVAIBb190OgXJ0mBSnifWKP2dDpBx4ytPYCIWyE4RY6q4Kuz/YR AGW2p7uLHRR5h5yH8L7G5s/98cPqtDf2CIHFq01aLpTCLdDsxWakkvevqX8UjvLu PYxMessjhXO4ZrqyE746H/joTDp/4rp+1HR2wHOb4OEy6zb/Cm3LYG6TCoXrDn9a 8IIPmzQAi2s/N6kh6l3IYqvXOBERoSksjAeC2cAUVHFcZ61PlTgn9lIzcFSQPIOS +wDmDi58aZ8z6CHnJZI1sDsnfUm69gP6zHNyM9dVRPsikD6xYHBO3r8elb/JNrE= =iEHv -----END PGP SIGNATURE----- --h6MnvR3fbpiG26Aa3dgUdSbase3rF7SLe--