From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36213)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1bDTxG-0007tt-Ro
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 05:51:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1bDTxC-0000q5-Sk
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 05:51:18 -0400
References: <1466066426-16657-1-git-send-email-berrange@redhat.com>
	<1466066426-16657-39-git-send-email-berrange@redhat.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <5762768E.80207@redhat.com>
Date: Thu, 16 Jun 2016 11:51:10 +0200
MIME-Version: 1.0
In-Reply-To: <1466066426-16657-39-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 38/40] trace: split out trace events for
 target-ppc/ directory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, =?UTF-8?Q?Llu=c3=ads_Vilanova?= <vilanova@ac.upc.edu>, qemu-ppc@nongnu.org

On 16.06.2016 10:40, Daniel P. Berrange wrote:
> Move all trace-events for files in the target-ppc/ directory to
> their own file.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  Makefile.objs           | 1 +
>  target-ppc/trace-events | 5 +++++
>  trace-events            | 4 ----
>  3 files changed, 6 insertions(+), 4 deletions(-)
>  create mode 100644 target-ppc/trace-events
> 
> diff --git a/Makefile.objs b/Makefile.objs
> index f1e8646..ad7419b 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -155,3 +155,4 @@ trace-events-y += audio/trace-events
>  trace-events-y += net/trace-events
>  trace-events-y += target-sparc/trace-events
>  trace-events-y += target-s390x/trace-events
> +trace-events-y += target-ppc/trace-events
> diff --git a/target-ppc/trace-events b/target-ppc/trace-events
> new file mode 100644
> index 0000000..d37da2b
> --- /dev/null
> +++ b/target-ppc/trace-events
> @@ -0,0 +1,5 @@
> +# See docs/trace-events.txt for syntax documentation.
> +
> +# target-ppc/kvm.c
> +kvm_failed_spr_set(int str, const char *msg) "Warning: Unable to set SPR %d to KVM: %s"
> +kvm_failed_spr_get(int str, const char *msg) "Warning: Unable to retrieve SPR %d from KVM: %s"
> diff --git a/trace-events b/trace-events
> index 63233e3..343e65a 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -119,10 +119,6 @@ kvm_device_ioctl(int fd, int type, void *arg) "dev fd %d, type 0x%x, arg %p"
>  kvm_failed_reg_get(uint64_t id, const char *msg) "Warning: Unable to retrieve ONEREG %" PRIu64 " from KVM: %s"
>  kvm_failed_reg_set(uint64_t id, const char *msg) "Warning: Unable to set ONEREG %" PRIu64 " to KVM: %s"
>  
> -# target-ppc/kvm.c
> -kvm_failed_spr_set(int str, const char *msg) "Warning: Unable to set SPR %d to KVM: %s"
> -kvm_failed_spr_get(int str, const char *msg) "Warning: Unable to retrieve SPR %d from KVM: %s"
> -
>  # TCG related tracing (mostly disabled by default)
>  # cpu-exec.c
>  disable exec_tb(void *tb, uintptr_t pc) "tb:%p pc=0x%"PRIxPTR
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>