From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDWGA-0006Hz-3P for qemu-devel@nongnu.org; Thu, 16 Jun 2016 08:18:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDWG4-0007Yq-1u for qemu-devel@nongnu.org; Thu, 16 Jun 2016 08:18:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:59005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDWG3-0007Ug-On for qemu-devel@nongnu.org; Thu, 16 Jun 2016 08:18:51 -0400 References: <1466071320-10964-1-git-send-email-jgross@suse.com> <481f9b77db71494d81ea43dada59abf0@AMSPEX02CL03.citrite.net> From: Juergen Gross Message-ID: <57629924.105@suse.com> Date: Thu, 16 Jun 2016 14:18:44 +0200 MIME-Version: 1.0 In-Reply-To: <481f9b77db71494d81ea43dada59abf0@AMSPEX02CL03.citrite.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant , "qemu-devel@nongnu.org" , "xen-devel@lists.xensource.com" Cc: Anthony Perard , "sstabellini@kernel.org" , "kraxel@redhat.com" On 16/06/16 13:24, Paul Durrant wrote: >> -----Original Message----- >> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of >> Juergen Gross >> Sent: 16 June 2016 11:02 >> To: qemu-devel@nongnu.org; xen-devel@lists.xensource.com >> Cc: Anthony Perard; Juergen Gross; sstabellini@kernel.org; >> kraxel@redhat.com >> Subject: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 >> word size mix >> >> In case the word size of the domU and qemu running the qdisk backend >> differ BLKIF_OP_DISCARD will not work reliably, as the request >> structure in the ring have different layouts for different word size. >> >> Correct this by copying the request structure in case of different >> word size element by element in the BLKIF_OP_DISCARD case, too. >> >> Signed-off-by: Juergen Gross > > Would it not be better to re-import the canonical blkif header as a whole rather than cherry-picking like this? You'd need to post-process to maintain style and possibly change some names for compatibility etc. but probably nothing beyond what indent and a simple [s]ed script can do. > I did broadly the same thing to re-import the netif header into Linux recently. It's a little bit more than indent/sed, but nothing really scary. I'll do it. Juergen