From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDYBf-0003w3-4U for qemu-devel@nongnu.org; Thu, 16 Jun 2016 10:22:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDYBd-0004GZ-2O for qemu-devel@nongnu.org; Thu, 16 Jun 2016 10:22:26 -0400 References: <1465939839-30097-1-git-send-email-eblake@redhat.com> <1465939839-30097-17-git-send-email-eblake@redhat.com> <20160616055000.GR12178@ad.usersys.redhat.com> From: Eric Blake Message-ID: <5762B617.2070805@redhat.com> Date: Thu, 16 Jun 2016 08:22:15 -0600 MIME-Version: 1.0 In-Reply-To: <20160616055000.GR12178@ad.usersys.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0kw80s6fFDETJQ0misg4X11a35aiJr8Ic" Subject: Re: [Qemu-devel] [PATCH v2 16/17] block: Split bdrv_merge_limits() from bdrv_refresh_limits() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com, Stefan Hajnoczi , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0kw80s6fFDETJQ0misg4X11a35aiJr8Ic Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/15/2016 11:50 PM, Fam Zheng wrote: > On Tue, 06/14 15:30, Eric Blake wrote: >> The raw block driver was blindly copying all limits from bs->file, >> even though: 1. the main bdrv_refresh_limits() already does this >> for many of gthe limits, and 2. blindly copying from the children >=20 > s/gthe/the ? Yep. [Sometimes it's interesting to stick in a typo, just to see who notices. Other times it's just me fat-fingering things] >=20 >> can weaken any stricter limits that were already inherited from >> the backing dhain during the main bdrv_refresh_limits(). Also, >> the next patch is about to move .request_alignment into >> BlockLimits, and that is a limit that should NOT be copied from >> other layers in the BDS chain. >> >> Solve the issue by factoring out a new bdrv_merge_limits(), >> and using that function to properly merge limits when comparing >> two BlockDriverState objects. >> >> Signed-off-by: Eric Blake >=20 > Reviewed-by: Fam Zheng >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0kw80s6fFDETJQ0misg4X11a35aiJr8Ic Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXYrYXAAoJEKeha0olJ0NqF4IH/3OURfgnZtQWQ+fJkzzof0BO cemw6Z0Wn5lqJHpzj+0JaiA6sWP/73x2CRNcyKbJFS0lEHMmH9yf9DHP2fBT03Of ZS/rmnWt56vH2vdgbMvwxo6PjOt2XGJt+873vL9awqcugC4fKAIYkB0GRohEM+5p mvn8g9LfLWupXbMY9jwv5Vr+JjKhsdCOntWv57QS8ETgaT3P3euzK/8xJPwTH1ET t3gqwLXebLqjz7iGpQhHHP1M12ffVr6rSYj7PARjScpb7nPudUmL6G9t0ksuCdj3 IpwtfxlMtte94rzTDdU6VWF+pt0YPwrgYaHMzkst6rJhdeteRNoX+I7R9vCb3to= =EY5J -----END PGP SIGNATURE----- --0kw80s6fFDETJQ0misg4X11a35aiJr8Ic--