Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

On 06/16/2016 08:46 AM, Markus Armbruster wrote:
> Markus Armbruster <armbru@redhat.com> writes:
> 
>> Eric Blake <eblake@redhat.com> writes:
>>
>>> Rather than having two separate visitor callbacks with items
>>> already broken out, pass the actual QAPISchemaObjectType object
>>> to the visitor.  This lets the visitor access things like
>>> type.is_implicit() without needing another parameter, resolving
>>> a TODO from previous patches.
>>>
>>> For convenience and consistency, the 'name' and 'info' parameters
>>> are still provided, even though they are now redundant with
>>> 'typ.name' and 'typ.info'.
>>>
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>
>> We've seen this one before :)
>>

>>
>> End quote.  Let's see how this series profits from the patch, and
>> whether we want to change the other visit methods as well for
>> consistency.
> 
> Where is this used in the rest of the series?

Hmm, I don't know that it actually makes a difference, unless we expand
its scope to also do the same things for commands and events (rather
than adding a 'box' parameter to those callbacks).

And deferring it doesn't break things anywhere else in this series.  I
guess we drop it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]