From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDaxp-0001oj-EJ for qemu-devel@nongnu.org; Thu, 16 Jun 2016 13:20:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDaxj-0008Lq-Gx for qemu-devel@nongnu.org; Thu, 16 Jun 2016 13:20:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDaxj-0008Ll-AB for qemu-devel@nongnu.org; Thu, 16 Jun 2016 13:20:15 -0400 References: <1463784024-17242-1-git-send-email-eblake@redhat.com> <1463784024-17242-2-git-send-email-eblake@redhat.com> <877fdsdk3v.fsf@dusky.pond.sub.org> <87mvmlyywi.fsf@dusky.pond.sub.org> From: Eric Blake Message-ID: <5762DFCD.3060004@redhat.com> Date: Thu, 16 Jun 2016 11:20:13 -0600 MIME-Version: 1.0 In-Reply-To: <87mvmlyywi.fsf@dusky.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x0Eo36wTbGJKOxMQFXEock3UqHMdKAE0L" Subject: Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --x0Eo36wTbGJKOxMQFXEock3UqHMdKAE0L Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/16/2016 08:46 AM, Markus Armbruster wrote: > Markus Armbruster writes: >=20 >> Eric Blake writes: >> >>> Rather than having two separate visitor callbacks with items >>> already broken out, pass the actual QAPISchemaObjectType object >>> to the visitor. This lets the visitor access things like >>> type.is_implicit() without needing another parameter, resolving >>> a TODO from previous patches. >>> >>> For convenience and consistency, the 'name' and 'info' parameters >>> are still provided, even though they are now redundant with >>> 'typ.name' and 'typ.info'. >>> >>> Signed-off-by: Eric Blake >> >> We've seen this one before :) >> >> >> End quote. Let's see how this series profits from the patch, and >> whether we want to change the other visit methods as well for >> consistency. >=20 > Where is this used in the rest of the series? Hmm, I don't know that it actually makes a difference, unless we expand its scope to also do the same things for commands and events (rather than adding a 'box' parameter to those callbacks). And deferring it doesn't break things anywhere else in this series. I guess we drop it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --x0Eo36wTbGJKOxMQFXEock3UqHMdKAE0L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXYt/NAAoJEKeha0olJ0NqZv8IAI3ZGAmx5RVjdSqZqdxyb5aK 64i4endOcjqqMW5vgsnseRt+hLBHssGTn4MQr3DJg67u9FeNUQce+3N6h65W1Bdq ZAg3LUVr1ZQxpRmUAIphh/0bidh2TaJ7kNyePlvfFKMQFK7zA0L7wkJgDfC6jFdc nkC/yIdUGPHHHr9uwpJDXC1ZAzk7co2nLFaPJlGBfsooJui6v3MR/ZfYT0lwnXO7 AGS3VRpQ1tL39T9xCul1MOltb5Z/+JnIKX4KubdHlSMu+lq4aY0c5+epgnNBNTsQ EmoAKK81PqHm6H+T4JsvWS/uHNyTl1OwpvK3g+klmW114ZoiFWaOOoMs30QiRwo= =f5FG -----END PGP SIGNATURE----- --x0Eo36wTbGJKOxMQFXEock3UqHMdKAE0L--