From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDqLb-0001W4-CB for qemu-devel@nongnu.org; Fri, 17 Jun 2016 05:45:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDqLW-0000oG-Bm for qemu-devel@nongnu.org; Fri, 17 Jun 2016 05:45:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:45957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDqLW-0000oC-4k for qemu-devel@nongnu.org; Fri, 17 Jun 2016 05:45:50 -0400 References: <1466154874-6218-1-git-send-email-jgross@suse.com> <5763DE5D02000078000F5FF8@prv-mh.provo.novell.com> From: Juergen Gross Message-ID: <5763C6CA.4090705@suse.com> Date: Fri, 17 Jun 2016 11:45:46 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant , Jan Beulich Cc: Anthony Perard , xen-devel , "sstabellini@kernel.org" , "qemu-devel@nongnu.org" , "kraxel@redhat.com" On 17/06/16 11:37, Paul Durrant wrote: >> -----Original Message----- >> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of Jan >> Beulich >> Sent: 17 June 2016 10:26 >> To: Juergen Gross >> Cc: Anthony Perard; xen-devel; sstabellini@kernel.org; qemu- >> devel@nongnu.org; kraxel@redhat.com >> Subject: Re: [Xen-devel] [PATCH v2] xen: fix qdisk BLKIF_OP_DISCARD for >> 32/64 word size mix >> >>>>> On 17.06.16 at 11:14, wrote: >>> In case the word size of the domU and qemu running the qdisk backend >>> differ BLKIF_OP_DISCARD will not work reliably, as the request >>> structure in the ring have different layouts for different word size. >>> >>> Correct this by copying the request structure in case of different >>> word size element by element in the BLKIF_OP_DISCARD case, too. >>> >>> The easiest way to achieve this is to resync hw/block/xen_blkif.h with >>> its original source from the Linux kernel. >>> >>> Signed-off-by: Juergen Gross >>> --- >>> V2: resync with Linux kernel version of hw/block/xen_blkif.h as >>> suggested by Paul Durrant >> >> Oh, I didn't realize he suggested syncing with the Linux variant. >> Why not with the canonical one? I have to admit that I particularly >> dislike Linux'es strange union-izng, mainly because of it requiring >> this myriad of __attribute__((__packed__)). >> > > Yes, it's truly grotesque and such things should be blown away with extreme prejudice. Sorry, I'm confused now. Do you still mandate for the resync or not? Resyncing with elimination of all the __packed__ stuff seems not to be a proper alternative as this would require a major rework. So either I do a resync and keep this stuff or I don't resync at all. Juergen