From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEfw9-0006c2-HZ for qemu-devel@nongnu.org; Sun, 19 Jun 2016 12:51:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEfw4-0006Zw-Gc for qemu-devel@nongnu.org; Sun, 19 Jun 2016 12:51:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEfw4-0006Zc-B4 for qemu-devel@nongnu.org; Sun, 19 Jun 2016 12:51:00 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 816403B720 for ; Sun, 19 Jun 2016 16:50:59 +0000 (UTC) References: <1466022773-8965-1-git-send-email-ehabkost@redhat.com> <1466022773-8965-11-git-send-email-ehabkost@redhat.com> <5766CAB9.9000608@redhat.com> From: Marcel Apfelbaum Message-ID: <5766CD70.6010408@redhat.com> Date: Sun, 19 Jun 2016 19:50:56 +0300 MIME-Version: 1.0 In-Reply-To: <5766CAB9.9000608@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/10] machine: Skip global registration for non-existing classes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org, Markus Armbruster Cc: Paolo Bonzini , Igor Mammedov On 06/19/2016 07:39 PM, Marcel Apfelbaum wrote: > On 06/15/2016 11:32 PM, Eduardo Habkost wrote: >> MachineClass::compat_props may point to class names that are not >> compiled into the QEMU binary. Skip registering those as global >> properties. This will allow the qdev global property code to >> implement stricter checks on the global property values in the >> future. >> >> Signed-off-by: Eduardo Habkost >> --- >> hw/core/machine.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/hw/core/machine.c b/hw/core/machine.c >> index d6f6be4..51697cb 100644 >> --- a/hw/core/machine.c >> +++ b/hw/core/machine.c >> @@ -583,6 +583,7 @@ static void machine_class_finalize(ObjectClass *klass, void *data) >> void machine_register_compat_props(MachineState *machine) >> { >> MachineClass *mc = MACHINE_GET_CLASS(machine); >> + ObjectClass *oc; >> int i; >> GlobalProperty *p; >> >> @@ -592,6 +593,14 @@ void machine_register_compat_props(MachineState *machine) >> >> for (i = 0; i < mc->compat_props->len; i++) { >> p = g_array_index(mc->compat_props, GlobalProperty *, i); > > Hi Eduardo, > >> + >> + /* Skip registering globals for non-existing device classes */ >> + oc = object_class_by_name(p->driver); > > This I understand. It ensure a corresponding class is in QEMU binary. > But even so, if such property is not available should we silently continue? > Maybe the user things the property is set... Please forgive the spelling errors and disregard the above question. > > >> + oc = object_class_dynamic_cast(oc, TYPE_DEVICE); > > This I don't understand. Do we check here? > Regarding my last question, it seems you followed an existing pattern here, however I don't quite understand, we found the class, why do we need to ensure is a TYPE_DEVICE? What error case do we want to prevent? Thanks, Marcel > Thanks, > Marcel > >> + if (!oc) { >> + continue; >> + } >> + >> /* Machine compat_props must never cause errors: */ >> p->errp = &error_abort; >> qdev_prop_register_global(p); >> >